Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ClusterClass support #75

Closed
richardcase opened this issue Feb 14, 2023 · 6 comments · Fixed by #261
Closed

Add ClusterClass support #75

richardcase opened this issue Feb 14, 2023 · 6 comments · Fixed by #261
Assignees
@salasberryfin
Labels
area/bootstrap Indicates an issue or PR related to the bootstrap provider area/controlplane Indicates an issue or PR related to the control plane provider kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.3.0

Comments

@richardcase
Copy link
Contributor

Describe the solution you'd like:
I'd like to be able to use ClusterClass with the RKE2 provider.

Why do you want this feature:
I am want to create instances of a class that uses the RKE2 controlplane and bootstrap providers.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@richardcase richardcase added kind/feature New feature or request needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/bootstrap Indicates an issue or PR related to the bootstrap provider area/controlplane Indicates an issue or PR related to the control plane provider priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates an issue or PR needs a priority assigning to it needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 14, 2023
@belgaied2 belgaied2 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 1, 2023
@richardcase richardcase added this to the v0.1.0-alpha.2 milestone Mar 1, 2023
@belgaied2 belgaied2 modified the milestones: v0.1.0-alpha.2, coming-next Mar 24, 2023
@salasberryfin
Copy link
Contributor

After discussion with @richardcase & @furkatgofurov7, I will work on this.

@salasberryfin salasberryfin self-assigned this Jun 16, 2023
@github-actions
Copy link

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2023
@ThomasVitale
Copy link

@salasberryfin should the "stale" label be removed?

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2023
@salasberryfin
Copy link
Contributor

salasberryfin commented Sep 27, 2023 •
edited

@ThomasVitale sorry I haven't been able to spend time on this. I'll delete my assignment in case someone is willing to work on this and come back later to it if it's still open.

@salasberryfin salasberryfin removed their assignment Sep 27, 2023
@Danil-Grigorev Danil-Grigorev self-assigned this Oct 12, 2023
@Danil-Grigorev Danil-Grigorev mentioned this issue Oct 12, 2023
Closed
@richardcase richardcase self-assigned this Oct 30, 2023
@richardcase richardcase modified the milestones: coming-next, v0.3.0 Nov 27, 2023
@salasberryfin salasberryfin self-assigned this Dec 11, 2023
@salasberryfin salasberryfin mentioned this issue Dec 27, 2023
Closed
4 tasks
@salasberryfin
Copy link
Contributor

salasberryfin commented Jan 23, 2024 •
edited

There's an upstream PR kubernetes-sigs/cluster-api#9952 that has been merged but we're waiting for it to be released before merging this.

@salasberryfin
Copy link
Contributor

  • The upstream issue that's currently blocking this from being merged is expected to be released in cluster-api:v1.7 (~april). Not having this functionality in core CAPI means that the provisioning of Docker machines might fail intermittently but, after discussing with the team, we consider that this shouldn't prevent us from having this supported in CAPRKE2.
  • As cluster-api-provider-rke2 is now at version v1beta1, the support for Cluster Class must be migrated to the new API version.

@salasberryfin salasberryfin mentioned this issue Feb 8, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salasberryfin salasberryfin

Labels
area/bootstrap Indicates an issue or PR related to the bootstrap provider area/controlplane Indicates an issue or PR related to the control plane provider kind/feature New feature or request priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
CAPI & Hosted Kubernetes providers (EKS/AKS/GKE)
Archived in project
Milestone
v0.3.0
6 participants
@kkaempf @richardcase @ThomasVitale @salasberryfin @Danil-Grigorev @belgaied2