Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal for deleting a POD treats success as failure #11247

Closed
richard-cox opened this issue Jun 15, 2024 · 1 comment · Fixed by #11307
Closed

Modal for deleting a POD treats success as failure #11247

richard-cox opened this issue Jun 15, 2024 · 1 comment · Fixed by #11307
Assignees
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression size/1 Size Estimate 1
Milestone

Comments

@richard-cox
Copy link
Member

Setup

  • Rancher version: 2.9.0 (pre release)

Describe the bug

  • The modal shown to confirm deletion of a pod has an async button
  • On pressing it for delete the api call is made
  • Even when this succeeds the modal remains and the button changes to Error

To Reproduce

  • Create a simple pod (any name, image nginx)
  • Find the pod in the pods list and use the three dot menu to delete
  • Click delete in the modal

Result

  • API request succeeds but modal remains, button shows Error text

Expected Result

  • On failure to delete the failure is shown in the modal
  • On delete success the modal is closed

Additional context

  • Deleting other resources like configmaps, secrets, deployments, etc work fine
@richard-cox richard-cox added this to the v2.9.0 milestone Jun 15, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jun 15, 2024
@nwmac nwmac added the size/1 Size Estimate 1 label Jun 27, 2024
@nwmac nwmac self-assigned this Jun 27, 2024
@yonasberhe23
Copy link
Contributor

e2e test is sufficient. moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression size/1 Size Estimate 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants