Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue3: Popover regressions in header #11684

Closed
2 tasks
rak-phillip opened this issue Aug 22, 2024 · 3 comments · Fixed by #11771
Closed
2 tasks

Vue3: Popover regressions in header #11684

rak-phillip opened this issue Aug 22, 2024 · 3 comments · Fixed by #11771
Assignees
@aalves08 @momesgin
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression
Milestone
v2.10.0

Comments

@rak-phillip
Copy link
Member

rak-phillip commented Aug 22, 2024 •
edited
Loading

The popovers used in the header have regressed in the following ways:

  1. They are styled incorrectly and do not match the global theme
  2. The remain open and cannot be closed

Affected components

  • User popover
  • Set as login page popover

Acceptance Criteria

  • Affected components match the style, as it was defined in v2.9.0
  • Affected components can open and close in the same way as they did in v2.9.0

Screenshots

set-as-login-popover
user-popover

Additional info
@rak-phillip rak-phillip added regression area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Aug 22, 2024
@rak-phillip rak-phillip added this to the v2.10.0 milestone Aug 22, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 22, 2024
This was referenced Aug 27, 2024
Closed
Closed
@cnotv
Copy link
Contributor

cnotv commented Aug 28, 2024

other related issues
#11742
#11740

@rak-phillip rak-phillip mentioned this issue Aug 28, 2024
Closed
@rak-phillip
Copy link
Member Author

There's a floating-vue migration guide that might be useful1 for debugging some of the regressions.

Footnotes

  1. https://floating-vue.starpad.dev/migration/migration-from-v2 ↩

@aalves08 aalves08 mentioned this issue Aug 29, 2024
Merged
7 tasks
@aalves08 aalves08 self-assigned this Aug 29, 2024
@aalves08 aalves08 mentioned this issue Aug 29, 2024
Merged
7 tasks
@momesgin momesgin self-assigned this Aug 30, 2024
@izaac
Copy link
Contributor

izaac commented Sep 7, 2024

Is mostly styling, and the auth provider issue is not yet automated but tasks are in the QA Task UI project.

@izaac izaac closed this as completed Sep 7, 2024
@izaac izaac mentioned this issue Sep 20, 2024
Closed
@cnotv cnotv mentioned this issue Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalves08 aalves08

@momesgin momesgin

Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging a pull request may close this issue.

Fix Vue3: Popover regressions in header aalves08/dashboard
6 participants
@izaac @rak-phillip @cnotv @richard-cox @aalves08 @momesgin