-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFE] Leverage resource-sync mechanism for resources that need created before cluster-agent comes up #11892
Comments
@Sahota1225 , @thatmidwesterncoder We need to discuss the implementation before starting this, was there an RFC? |
/backport v2.9.next2 |
See UI JIRA for implementation details SURE-9078 |
Blocked on SURE-5434 |
/backport v2.8.9 |
|
Rancher version: Tested on vSphere 8 in a vSphere local cluster using Downstream vSphere clusters. These are referenced during vSphere provisioning using the vSphere cloud provider. Deselecting auto generate secrets from the Add Ons, the secrets are automatically picked up and used for pre-bootstrap during provision. Scope here was only vSphere. As per the Linked PRs. |
Is your feature request related to a problem? Please describe.
Currently there is a gap where certain resources that are required by system components (e.g. additionalManifests) are stored in plain text on the cluster object. After rancher/rancher#45718 is completed there will be a way to synchronize resources (at first just secrets) to the downstream clusters during the provisioning process by way of a specific annotation (docs soon).
The UI should use this feature where necessary to ensure that potentially sensitive manifests do not end up on disk.
Describe the solution you'd like
When creating a cluster through the wizard - the UI should create other resources (namely secrets) first with the appropriate annotation and then the cluster object, which would allow the provisioning process to bring up the cluster -> create those secrets -> then continue the provisioning process.
Describe alternatives you've considered
Mentioned in the r/r issue above, namely using
additionalManifests
ormachineSelectorFiles
. But those require the files to be placed on disk before being applied by RKE2.Additional context
This will most likely complicate the UI in certain places (the additional config tab mostly) because creates will create the secret, then updates will update said secret. Hopefully it can be abstracted away to hook into it wherever there is something sensitive.
Related: Parent - SURE-5434, UI - SURE-9078
The text was updated successfully, but these errors were encountered: