Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Edit Config on local EKS cluster #12339

Closed
rolfbartels opened this issue Oct 23, 2024 · 8 comments · Fixed by #12583
Closed

[BUG]Edit Config on local EKS cluster #12339

rolfbartels opened this issue Oct 23, 2024 · 8 comments · Fixed by #12583
Assignees
Labels
area/eks JIRA kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this status/backport-candidate
Milestone

Comments

@rolfbartels
Copy link

Rancher Server Setup

  • Rancher version: 2.92
  • Installation option (Docker install/Helm Chart): Helm
    • If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): EKS
  • Proxy/Cert Details: Rancher Cert from Cert Manager

Information about the Cluster

  • Kubernetes version: 1.30
  • Cluster Type (Local/Downstream): local
  • Hosted = EKS

User Information

  • What is the role of the user logged in? Admin/Cluster Owner

Describe the bug
On a new install or old install on Rancher 2.9.2 I want to add labels to the local cluster.
When I edit the config I am prompted that atleast 1 node group must be configured.
I insert the missing field (Cluster Name, Cloud Creds (Same Creds use to eksctl create), add a node group and try and save.

I am presented on and error
{"data":""}

To Reproduce
Cluster Management
Select the ellipsis for local cluster
Edit Config
Enter in required details
Save

Result
{"data":""}
Expected Result
Cluster Config saves

Screenshots
image

Additional context

@rak-phillip
Copy link
Member

@rolfbartels thanks for raising this issue and helping to make Rancher better! Our team might follow-up for to collect more information as we triage the issue.

@gaktive transferring to the Dashboard repo for triage. This could be related to SURE-9216

@rak-phillip rak-phillip transferred this issue from rancher/rancher Oct 23, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Oct 23, 2024
@gaktive gaktive added this to the v2.10.0 milestone Oct 23, 2024
@rak-phillip
Copy link
Member

I can repro this issue in v2.9.3. The form behaves exactly as described when editing the local cluster for Rancher hosted on EKS

@gaktive
Copy link
Member

gaktive commented Oct 29, 2024

@mantis-toboggan-md this feels like something we can tackle in 2.11.0 and 2.10.1 but can you take a quick look to see how easy a fix could be?

@mantis-toboggan-md
Copy link
Member

mantis-toboggan-md commented Oct 29, 2024

@gaktive I have looked into this and spoken about it a little with Phil. Investigation is ongoing; we don't yet know if this is a frontend, backend, or combined bug. Given that, I'd say it's not a good candidate for 2.10.0.

@rak-phillip
Copy link
Member

Following up with some information based on OOB discussions. We've identified that the behavior described in the issue is related to eksStatus.upstreamSpec evaluating to null and eksConfig is undefined. This has been reported to be expected behavior:

on local cluster where Rancher is running, and even if it was deployed on EKS eksStatus should be:

eksStatus:
  generatedNodeRole: ''
  managedLaunchTemplateID: ''
  managedLaunchTemplateVersions: null
  privateRequiresTunnel: null
  securityGroups: null
  subnets: null
  upstreamSpec: null
  virtualNetwork: ''

it is because local cluster is not provisioned or managed by eks-operator

Based on the information provided, I think that we will need to define the edge-cases for working with local clusters and handle them accordingly so that the form behaves as expected for this use case.

@nwmac nwmac modified the milestones: v2.12.0, v2.11.0 Nov 1, 2024
@gaktive
Copy link
Member

gaktive commented Nov 1, 2024

/backport v2.10.1

@mantis-toboggan-md
Copy link
Member

/backport v2.9.5

@izaac
Copy link
Contributor

izaac commented Dec 13, 2024

Rancher version: v2.11-215cf156eb44fd6b392ef5d65d38e8dcafeb2734-head
UI version: release-2.10 d5b785b
EKS cluster version: v1.30.7-eks-56e63d8

This is meeting the expectation. No errors are observed when adding new labels or updating the cluster members.

@izaac izaac closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment