-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose refreshInterval
input field for cluster repos
#12759
Conversation
In terms of consistency (although I don't love the component itself), we probably should use the input field with unit: If not, at least I would change the label and placeholder to:
And, ideally, it could just sit inside the "Target" section without its own header, since it's just a setting related to the repo target (how often it's fetched). @kwwii are you ok with this? |
@edenhernandez-suse Yes, I agree with using the component we have now for showing the units as suggested. |
@kwwii @edenhernandez-suse thank you for reviewing, so does this mean we should update the OCI inputs as well to use the same unit input component for consistency? To be more clear, only two of the three input fields for OCI are in seconds, the number of retries input is just a number. |
Sorry @momesgin I didn't see the OCI options at the end of the video (in these cases I think having screenshots is a bit better to ensure we don't miss anything). Yes, if a field has units, ideally it should use the component with units. The number of retries has no units so that's fine, a regular input type number is perfect. However, the components with units are huge (we should redesign them at some point), so the layout might break. Please ping me in Slack or here if that happens and I'll try to provide a solution. |
No worries at all @edenhernandez-suse , I had a meeting with Ken yesterday re this issue. I'm currently working on fixing e2e tests after switching to the UnitInput component, I'll reach out either here or on Slack once I'm finished with that. |
@edenhernandez-suse here is the final result: please let me know if anything needs to be changed |
All good! |
9873bd6
Summary
Fixes #12486
Occurred changes and/or fixed issues
New labeled input added to the cluster repo page to let users to change the
refreshInterval
for their cluster repos.Areas or cases that should be tested
Test the create/edit modes with/without changing the
refreshInterval
Areas which could experience regressions
n/a
Screenshot/Video
refreshinterval.mov
Checklist