Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare performance of side nav cluster list pre and post SSP change #12831

Open
richard-cox opened this issue Dec 6, 2024 · 0 comments
Open
Assignees
Labels
area/server-side-pagination kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@richard-cox
Copy link
Member

  • Add server-side pagination to home page cluster list #11663 brought in a change in how the side nav calculates the clusters to show
  • Previously a computed property references mgmt and prov cluster lists and would re-run on changes (like a cluster coming online / going offline)
  • Now there is a set of watches on mgmt and prov cluster lists (which had to be deep). We should confirm that the amount of times the update runs given those changes aligns with the amount of times the computed properties ran before
  • Note - this only affects the world with SSP turned off
@richard-cox richard-cox added this to the v2.11.0 milestone Dec 6, 2024
@richard-cox richard-cox self-assigned this Dec 6, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-side-pagination kind/enhancement QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

1 participant