Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions workflow tests improvements #12875

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

aalves08
Copy link
Member

Summary

Fixes #

Occurred changes and/or fixed issues

  • fix script permissions in master extensions workflow tests that prevented it from running successfully
  • change extensions workflows tests titles so that they are not confusing when browsing github actions UI
  • add condition for extensions workflow tests not to run on forks
  • improve slack message job on extension workflows to handle "empty" status of jobs

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

…re not confusing when browsing github actions UI + add condition for wfs not to run on forks + improve slack messages to handle no empty status of jobs
@aalves08 aalves08 added this to the v2.11.0 milestone Dec 12, 2024
@aalves08 aalves08 self-assigned this Dec 12, 2024
@aalves08 aalves08 requested a review from jordojordo December 12, 2024 11:16
Copy link
Member

@jordojordo jordojordo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - Just curious, what would cause a "No job status"?

@aalves08
Copy link
Member Author

aalves08 commented Dec 12, 2024

lgtm - Just curious, what would cause a "No job status"?

A script not running because of permissions on the file 😛 It doesn't exit the job with either a success nor a failure apparently
https://github.com/rancher/dashboard/actions/runs/12287118973

Check the slack message job to see the echo's

@aalves08 aalves08 merged commit e115aa9 into rancher:master Dec 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants