-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink how we show nav links and keep top-level groups in menu all the time #4431
Comments
Alright so the crux of the issue is that the left navigation should never change. I get that what is probably trying to be done is focusing on namespace but we should treat it less as a filtering down a level from global to namespace and more of a way of aggregating multiple namespaced resources/shortcut for creation. That is what I'd suggest in simplest terms. Another thing we could consider doing is moving namespace filter to namespaced list places. This would take the guess work from list pages as to does this belong to global or namespace level? |
@vincent99 is there a reason or intention to those changes to the nav when namespace filters are applied? |
You're asking to see stuff that belongs to a [set of] namespace[s], so cluster-level resources are removed because they are non-namespaced by definition (e.g. nodes, persistent volumes, the namespace resource itself). |
Got it. I wasn't sure if this was intentional. Since we've gotten feedback that it's confusing we should change it so both cluster and namespaced resources are available. I've attached a few thoughts in the xd file. |
@nwmac to create work items from this and then this is Done. |
Capturing more feedback on the nav bar from talking to @cnotv :
I'm not sure if that falls under rethinking nav links or it should be in separate issues. |
Another issue may be also related to nested navigation, where the sidebar is replaced and there's nothing in the breadcrumb. Not sure in which way it can be solved, but it's kinda of annoying to need to navigate all the way back just to get the link in the sidebar. |
We've had requests from a customer to keep groups expanded when accessing resources outside of that group (details available on confluence) |
Internal reference SURE-3658 |
Also some connection with #5229 |
SURE-3658 |
I'm closing this issue due to its age and because the work on the side nav is being tracked in these other issues:
The epic ticket for navigation improvements in general is here: #6417 The relevant internal ticket is linked to #6658 #6658 (comment) |
In the midst of @rak-phillip researching what was going on with navigating between components in #4428, a bandaid solution to ensure that getting from Installed Apps to Apps & Marketplace can happen without hitting another page inbetween.
However, based on the wormhole of logic discovered when investigating that issue, we should figure out what we can do to keep more of the top-level groups persistent in the main navigation on the left side. At the very least, users should be able to get to the Cluster area all the time, which isn't available in some cases.
As part of that, we shouldn't remove the namespace resources when the namespace filter is enabled since the list on the left changes a fair bit if none, one or all are selected.
@vincent99 may provide some of the contextual history as to how the modes tied to index0, index1, etc. for the nav link were put into place. It looks like tech debt from a past change with maybe some remnants of older flow still around.
related issues:
The text was updated successfully, but these errors were encountered: