Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When creating/saving a GKE cluster validation for nodepools with same name does not happen #4465

Closed
Tracked by #5983
sowmyav27 opened this issue Aug 8, 2021 · 6 comments
Assignees
Labels
area/form-validation ember Ember UI Issue kind/bug QA/manual-test Indicates issue requires manually testing QA/S size/3 Size Estimate 3 team/highlander Highlander
Milestone

Comments

@sowmyav27
Copy link

If this is a UI issue, please file an issue at https://github.com/rancher/dashboard/

Rancher Server Setup

  • Rancher version: 2.6-head commit id: 0ab00d7
  • Installation option (Docker install/Helm Chart): Helm
    • If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): RKE1
  • Proxy/Cert Details: Rancher generated

Information about the Cluster

  • Kubernetes version: 1.20
  • Cluster Type (Local/Downstream): Downstream - GKE v2

Describe the bug
When creating/saving a GKE cluster validation for nodepools with same name does not happen

To Reproduce

  • Deploy a GKE v2 hosted cluster.
  • Have two nodepools with same name.
  • Create/Save cluster details
  • No error is seen during creation.
  • Error seen on cluster after deployment: Cluster [c-mf29m] cannot have multiple nodepools with name <nane>
  • Edit cluster, user does not have access to edit the nodepool name, but has to delete one and add another one.

Expected Result
When creating with same nodepool names, Error should be seen and not allow user to save details

@sowmyav27 sowmyav27 self-assigned this Aug 8, 2021
@Jono-SUSE-Rancher
Copy link

@vincent99 - Is this something where the front end should be doing validation prior to the user clicking to save/create the cluster details, or is this something where the API should toss an error message back indicating that duplicate nodepools with identical names is probably a no-no?

@vincent99
Copy link
Contributor

I don't think we attempt to do much server-side validation to replicate what google is going to say, so probably just frontend.

@cbron cbron transferred this issue from rancher/rancher Oct 27, 2021
@cbron cbron added this to the v2.6.3 milestone Oct 27, 2021
@gaktive gaktive modified the milestones: v2.6.3, v2.6.4 Nov 5, 2021
@gaktive gaktive modified the milestones: v2.6.4, v2.6.5 Feb 28, 2022
@nwmac nwmac modified the milestones: v2.6.5, v2.6.6 Mar 21, 2022
@nwmac
Copy link
Member

nwmac commented May 9, 2022

This is the same as another issue around allowing node pools with the same name - note that this is in the Ember UI

@nwmac nwmac modified the milestones: v2.7.0, v2.7.1 Sep 23, 2022
@gaktive gaktive modified the milestones: v2.7.2, v2.7.1 Oct 5, 2022
@markusewalker markusewalker modified the milestones: v2.7.1, v2.7.x Nov 2, 2022
@markusewalker markusewalker modified the milestones: v2.7.x, v2.7.next2 Jan 11, 2023
@sowmyav27 sowmyav27 added team/highlander Highlander and removed team/area2 Hostbusters labels May 11, 2023
@nwmac nwmac modified the milestones: v2.7.next2, v2.7.next3 May 11, 2023
@markusewalker markusewalker removed their assignment May 11, 2023
@nwmac nwmac modified the milestones: v2.7.next3, v2.7.next4 Jun 27, 2023
@nwmac nwmac modified the milestones: v2.8.0, v2.8.next1 Sep 27, 2023
@nwmac nwmac added [zube]: To Test QA/manual-test Indicates issue requires manually testing and removed [zube]: Review labels Jan 22, 2024
@IsaSih
Copy link

IsaSih commented Jun 13, 2024

This issue was tested on #9987

@IsaSih IsaSih closed this as completed Jun 13, 2024
@IsaSih IsaSih self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/form-validation ember Ember UI Issue kind/bug QA/manual-test Indicates issue requires manually testing QA/S size/3 Size Estimate 3 team/highlander Highlander
Projects
None yet
Development

No branches or pull requests

9 participants