Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX FIX: Elements in the "Header dropdown" should not be displayed as a link #6201

Closed
Tracked by #8813
manuelecarlini opened this issue Jun 21, 2022 · 9 comments
Closed
Tracked by #8813

Comments

@manuelecarlini
Copy link

Setup

  • Rancher version: 2.6
  • Browser type & version:

Describe the bug

The dropdown in the header bar shows different elements, but those are not link, we need to change the color and make it look like as menu items

Screenshot 2022-03-28 at 20 51 53

To Reproduce

Result

Expected Result

Screenshots

Additional context

Detailed Description

Context

@nwmac
Copy link
Member

nwmac commented Jul 13, 2022

@manuelecarlini This is the old namespace/project chooser - can you take a look at the latest UI - I'm not sure what you were proposing we change.

@kwwii kwwii added this to the v2.7.0 milestone Jul 19, 2022
@kwwii
Copy link
Contributor

kwwii commented Jul 19, 2022

I think this might be mainly fixed but we should verify the presentation.

@markusewalker
Copy link

@manuelecarlini can you provide a status update regarding this issue? I see it is in Review, but there is no associated PR to this ticket.

@markusewalker
Copy link

While we wait for this issue to be addressed, here is the QA test plan:

TEST PLAN

  1. Setup Rancher and navigate to the UI in a browser.
  2. Navigate to Cluster Explorer > local.
  3. In the dropdown menu that says Only User Namespaces, click that and verify if elements in the dropdown appear as different elements and not links.

@kwwii
Copy link
Contributor

kwwii commented Aug 23, 2022

For clarification, is this in the new UI or in the ember UI? I believe that this has been fixed in the new UI and doubt that it would be changed in the old one.

@markusewalker
Copy link

markusewalker commented Sep 1, 2022

@kwwii @gaktive circling back to this issue, can you please provide a PR where this has been addressed in the new UI so that QA can properly validate? If this has already been addressed, we can proceed forward with validating and closing this.

@catherineluse
Copy link
Contributor

I haven't found the PR, although I can confirm that in the latest version, the items in the nav aren't blue anymore:
Screen Shot 2022-09-08 at 1 14 10 PM

@markusewalker
Copy link

Thanks @catherineluse, I see the same as well. Considering this is a relatively smaller issue, I will go ahead and provide an official QA sign off in a new comment to validate this and close this issue.

@markusewalker
Copy link

Validated that this is addressed in v2.6-head rancher/rancher@f900172.

ENVIRONMENT DETAILS

TEST RESULT
PASS

VERIFICATION STEPS

  1. Setup Rancher and navigated to the UI in a browser.
  2. Navigated to Cluster Explorer > local.
  3. In the dropdown menu that says Only User Namespaces, clicked that and validated that the elements in the dropdown appear as different elements and not links:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants