Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements needed for the Diagnostic page #6739

Closed
sowmyav27 opened this issue Aug 24, 2022 · 8 comments · Fixed by #6990 or #7304
Closed

Enhancements needed for the Diagnostic page #6739

sowmyav27 opened this issue Aug 24, 2022 · 8 comments · Fixed by #6990 or #7304
Assignees
Milestone

Comments

@sowmyav27
Copy link

sowmyav27 commented Aug 24, 2022

Is your feature request related to a problem? Please describe.
Enhancements needed for the Diagnostic page

  1. Title - Diagnostics is vague and from users' pov, it isn't clear what is this page for. Could we add in something more appropriate since its for UI diagnostics?

Screen Shot 2022-08-24 at 11 22 11 AM

  1. Download data button --> It isn't intuitive, what data is going to get downloaded. Everything from the page? or just the log?

  2. Logs and Resource Counts --> These sections must have more info on what logs (Rancher logs or downstream clusters' logs or in this case logs from the browser ) are these and what resources are there (local cluster? or downstream cluster?)

  3. There are resources that have 0 count. can we not display these ?

Screen Shot 2022-08-24 at 11 25 43 AM

Additional context
Related to this feature - #6544

@sowmyav27 sowmyav27 changed the title <feature title: summarize feature in one line> Enhancements needed for the Diagnostic page Aug 24, 2022
@sowmyav27 sowmyav27 added this to the v2.6.8 milestone Aug 24, 2022
@aalves08
Copy link
Member

@kwwii can we take a look at this when we adjust the styling of this page and the about page? Thanks 🙏

@kwwii
Copy link
Contributor

kwwii commented Sep 9, 2022

Here's a mockup:
diagnostics.png

@aalves08
Copy link
Member

Hi @jordojordo , as discussed with @nwmac I am passing this one you. Thanks! 🙏 🙇

@aalves08 aalves08 assigned jordojordo and unassigned aalves08 Sep 16, 2022
@nwmac
Copy link
Member

nwmac commented Sep 19, 2022

@jordojordo We can discuss

@nwmac
Copy link
Member

nwmac commented Sep 20, 2022

Specifically:

  • Move the latest logs to the bottom
  • Compact the System Information table into 3 groups, use name/values with the table for each group
    • Browser
    • System
    • Javascript Memory
  • Resource counts - should collapsed by default when more than one cluster - label '
    • Label - Resource counts by cluster
    • Ignore counts when they are 0
    • When collapsed show the following info in the bar - Total resource count, Total number of nodes,
  • Allow timings to be shown on screen and for each cluster
    • Add a button 'Generate Diagnostic Data' which will go through each cluster, capture timing and add it to the table add another column, use '-' for those we did not time
  • Add dialog when users downloads if they have not run the timings against to let them know if they want them, they should use the other button first.
  • Add feedback to each cluster to say if timing info is available and show spinner when timing is being collected

@dasarinaidu
Copy link

Validated this issue on v2.7-9f1e0435bb45e104ba897c5c329e1f23735843d9-head
Browsers : Chrome and Firefox

Observation 1: On Diagnostic page : The button name should be 'Generate Diagnostic Data' from the requirement?

Steps :

  1. Login to rancher
  2. Navigate to 'About' Page
  3. Click on Diagnostics page
  4. Check for the button with name 'Generate Diagnostic Data'

Actual:

  1. Not seeing the button with name : 'Generate Diagnostic Data'; User seeing the button name as 'Generate Response Times'

image

Observation 2: Cluster Name is NOT showing for all cluster types (Displaying the cluster ID)
Steps:

  1. Login to rancher
  2. Navigate to 'About' Page
  3. Click on Diagnostics page
  4. Check for the Clusters Name associated to the user

Actual:

  1. Clusters list is displaying properly but the cluster name is not displaying properly (It is displaying the cluster ID) for some of the clusters and some of the cluster types it is displaying correct name
  2. Only RKE2 clusters are showing the correct cluster names
  3. RKE, EKS, GKE, AKS clusters are NOT showing the cluster names (Displaying cluster IDs)

Note :
a. I am seeing same information is displaying with v2.6.8

image

Observation 3: Firefox browser: System Information is not populating all the information
Steps:

  1. Login to rancher
  2. Navigate to 'About' Page
  3. Click on Diagnostics page
  4. Check for the System Information

Actual:

  1. System Information table missing below fields
    a. System : OS: macOS, Device Memory: 8
    b. Complete row : 'Javascript Memory Heap Size limit: 4294705152, Total Heap Size: 77133756, Used Heap Size: 70122148'
  2. Seeing this information on Chrome
  3. Screens attached from Chrome and FireFox

Note :
a. I checked the Javascript enabled flag set to true on my firefox but the full information is not displaying on Firefox
b. I am seeing same information is displaying with v2.6.8

image

Missing JavaScript and Memory details on FireFox.

image

@jordojordo
Copy link
Member

@dasarinaidu Two observations are not applicable.

On Diagnostic page : The button name should be 'Generate Diagnostic Data' from the requirement

  • The final wording was decided outside of the issue thread

Firefox browser: System Information is not populating all the information

@dasarinaidu
Copy link

Validations Completed and looks good.

Rancher Ver: v2.7-9f1e0435bb45e104ba897c5c329e1f23735843d9-head

Validated this card:

  1. Admin & Standard user
  2. Chrome & Firfox
  3. All cluster types
  4. Standard and Dark mode view

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment