Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change AKS "experimental" label to apply to k8s 1.25+ #7217

Closed
snasovich opened this issue Oct 18, 2022 · 5 comments
Closed

Change AKS "experimental" label to apply to k8s 1.25+ #7217

snasovich opened this issue Oct 18, 2022 · 5 comments

Comments

@snasovich
Copy link
Contributor

k8s versions 1.24+ are marked as "experimental" in Rancher UI per the change done in #6513

With AKS 1.24 tested and validated as working OK in Rancher, we don't want to have "experimental" label applied to 1.24 any longer.
However, 1.25 will be available in AKS sometime in October as Preview (and GA in December) per https://learn.microsoft.com/en-us/azure/aks/supported-kubernetes-versions?tabs=azure-cli#aks-kubernetes-release-calendar. Since it's not yet validated, we want to have it marked as "experimental" once it becomes available in AKS. That's the rationale for setting EXPERIMENTAL_RANGE = '>= 1.25.0' and not simply removing the functionality outright.

@jtravee
Copy link

jtravee commented Oct 18, 2022

Adding known issue to the 2.6.9 release note PR per @snasovich.

@catherineluse catherineluse self-assigned this Oct 19, 2022
@nwmac
Copy link
Member

nwmac commented Oct 19, 2022

@snasovich We're past code freeze for 2.7

@snasovich
Copy link
Contributor Author

@nwmac (cc: @gaktive ), 10-4.
Now, my understanding is that we have not cut final RC, so critical fixes can still go in. This is by no means a critical issue, however the fix is likely 1/2-line change. So if this is something that can be done in time for 2.7.0, that would be great.
If not, let's move it to 2.7.1 milestone.

@markusewalker
Copy link

QA TEST PLAN

Scenarios

Scenario Test Case
1 Setup fresh install of Rancher, attempt to provision an AKS cluster, validate that no listed K8s version shows as experimental
2 Setup v2.6.9 Rancher, attempt to provision an AKS cluster, validate that K8s versions 1.24+ show as experimental, upgrade Rancher, attempt to provision an AKS cluster, validate that no listed K8s version shows as experimental

@markusewalker
Copy link

Validated this against v2.7-head rancher/rancher@40932d6. Details below:

ENVIRONMENT DETAILS

  • Rancher install: Helm
  • Rancher version:
    • Fresh install: v2.7-head https://github.com/rancher/rancher/commit/40932d62cdeb2f4594009436468c444c3378553d
    • Upgrade: v2.6.9 -> v2.7-head https://github.com/rancher/rancher/commit/9e7e4bc5bb4ac18ae801fba3c076f10039267052
  • Browser: Chrome

TEST RESULT

Scenario Test Case Result
1 Setup fresh install of Rancher, attempt to provision an AKS cluster, validate that no listed K8s version shows as experimental
2 Setup v2.6.9 Rancher, attempt to provision an AKS cluster, validate that K8s versions 1.24+ show as experimental, upgrade Rancher, attempt to provision an AKS cluster, validate that no listed K8s version shows as experimental

VALIDATION STEPS

Scenario 1

  1. Setup Rancher, created a standard user and logged in as that user.
  2. Navigated to Cluster Management > Create > Azure AKS.
  3. Attempted to provision a cluster and in the Cluster Options validated that no K8s version shows as experimental:
    image

Scenario 2

  1. Repeated steps 1-3, but ensured that on step 3, that K8s version 1.24+ showed as experimental.
  2. Upgraded Rancher server, validated that the cluster and nodes still remain as Active in Cluster Management and Cluster Explorer.
    • Additionally, validated that the cluster DID NOT auto-upgrade upon upgrading Rancher server.
  3. Repeated steps 2-3 in scenario and validated that no K8s version shows as experimental:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants