Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Delivery: User is logged out after attempting to move a fleet cluster from a workspace to another owned by a different user #8623

Closed
izaac opened this issue Apr 4, 2023 · 7 comments
Milestone

Comments

@izaac
Copy link
Contributor

izaac commented Apr 4, 2023

Setup

  • Rancher version: v2.7-head 0c76b3f
  • Browser type & version: Firefox

Describe the bug

The user is taken back to the login page when trying to move a fleet cluster from a workspace (own or fleet-default) to other workspace owned by a different user.

To Reproduce

  • As admin user in Rancher
  • Create two users user1 and user2
  • Create a Custom Role and give all permissions to the resources gitrepo fleetworkspaces and clusters (fleet)
  • Assign this custom role to user1 and user2
  • Provision an RKE2 cluster in Rancher and add user1 and user2 as Cluster Owner.
  • As user1 navigate to Continous Delivery and check you can see the Clusters in fleet-default
  • As user1 create a new fleet workspace user1ws
  • As user2 navigate to Continous Delivery and check you can see the Clusters in fleet-default
  • As user2 create a new fleet workspace user2ws
  • Logout from both accounts.
  • Login as user2 navigate to Continuous Delivery move the RKE2 fleet cluster from fleet-default to user1ws

Result

An error occurs and user2 is logged out and taken back to the login page.

{
    "baseType": "error",
    "code": "Unauthorized",
    "message": "admission webhook \"rancher.cattle.io.clusters.management.cattle.io\" denied the request: Unauthorized",
    "status": 401,
    "type": "error"
}

Expected Result
Either being able to move the cluster to other workspace owned by other user.
If that's not expected. Just throw an error and do not log out the user

Screenshots

Moving to userws1
Screen Shot 2023-04-04 at 12 09 44 PM

Result:
Screen Shot 2023-04-04 at 12 10 10 PM

Additional context

Dashboard: release-2.7.2 94650da49
Fleet: v0.6.0-rc.5

@izaac izaac added this to the v2.7.2 milestone Apr 4, 2023
@izaac izaac changed the title Continuous Delivery: User is logged out after attempting to move a fleet cluster from a one workspace to another owned by a different user Continuous Delivery: User is logged out after attempting to move a fleet cluster from a workspace to another owned by a different user Apr 4, 2023
@gaktive
Copy link
Member

gaktive commented Apr 4, 2023

Doesn't read as a blocker based on the scenario but the behaviour is weird. Hopefully we can quickly check this out but this may be pushed out due to time.

@gaktive
Copy link
Member

gaktive commented Apr 4, 2023

@kkaempf what should be the desired behaviour in this case? Could a user expect to do this?

@gaktive gaktive modified the milestones: v2.7.2, v2.7.next2 Apr 4, 2023
@gaktive gaktive added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Apr 11, 2023
@Shavindra Shavindra self-assigned this May 4, 2023
@gaktive gaktive added size/2 Size Estimate 2 [zube]: Groomed and removed [zube]: Backlog labels May 17, 2023
@nwmac
Copy link
Member

nwmac commented May 24, 2023

See: #8479

We have removed the ability to move RKE2 clusters to different workspaces, so this resolves this issue until the backend is fixed to enable this to work - see: rancher/rancher#36132

@nwmac nwmac removed the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label May 24, 2023
@Sahota1225 Sahota1225 added the team/fleet Belongs to Team Fleet label May 30, 2023
@l4zy0n3
Copy link

l4zy0n3 commented Jun 6, 2023

See: #8479

We have removed the ability to move RKE2 clusters to different workspaces, so this resolves this issue until the backend is fixed to enable this to work - see: rancher/rancher#36132

Since we have disabled the ability to move clusters and the issue is open for a long time, we should mark it as stale and close this if no other work needs to reference this issue.

I was unable to reproduce the issue due to the reasons stated above.

@sbulage
Copy link

sbulage commented Jun 9, 2023

Below screenshot says, clearly that option to move workspace for the clusters has been remove.
Selection_023
Thanks @l4zy0n3

@prabalsharma
Copy link

Can be closed.

@kkaempf
Copy link

kkaempf commented Jun 14, 2023

.

@kkaempf kkaempf closed this as completed Jun 14, 2023
@zube zube bot removed the [zube]: Done label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants