Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize SeedImage building #112

Open
agracey opened this issue Mar 23, 2023 · 4 comments
Open

Memoize SeedImage building #112

agracey opened this issue Mar 23, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@agracey
Copy link

agracey commented Mar 23, 2023

Currently, if I go to the UI and click "Build ISO" a new SeedImage gets created. If I keep clicking this button, I end up with a bunch of pods all hosting the same thing.

Would it make more sense to add some labels/annotations to that SeedImage CR then match the requested config to allow for reuse?

@fgiudici
Copy link
Member

We somehow already do something that could be useful on the backend side: we have annotations tracking the base image, the referenced registration and the cloud init that would allow us to know if we should re-build the ISO or not on SeedImage update.
So, on the UI side keeping the same name for the seedimage (overwriting it if already present) may work 🤔
( CC @aalves08 )

@agracey
Copy link
Author

agracey commented May 19, 2023

Could we move this to the ui repo? (I don't have the correct permissions)

@kkaempf kkaempf transferred this issue from rancher/elemental May 19, 2023
@aalves08 aalves08 transferred this issue from rancher/dashboard May 19, 2023
@aalves08
Copy link
Member

Issue moved @agracey . I've asked for permissions to add the elemental group to the elemental-ui repo so that you could do this kind of operation (I don't have enough permissions to do that). 🙏

@aalves08 aalves08 self-assigned this May 19, 2023
@aalves08 aalves08 added the enhancement New feature or request label May 19, 2023
@aalves08
Copy link
Member

We somehow already do something that could be useful on the backend side: we have annotations tracking the base image, the referenced registration and the cloud init that would allow us to know if we should re-build the ISO or not on SeedImage update. So, on the UI side keeping the same name for the seedimage (overwriting it if already present) may work 🤔 ( CC @aalves08 )

I'll have to check if that will work. Thanks for the input @fgiudici 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants