Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight no-longer-in-sync ManagedOSVersions #183

Closed
anmazzotti opened this issue Jun 18, 2024 · 3 comments · Fixed by #187
Closed

Highlight no-longer-in-sync ManagedOSVersions #183

anmazzotti opened this issue Jun 18, 2024 · 3 comments · Fixed by #187

Comments

@anmazzotti
Copy link

anmazzotti commented Jun 18, 2024

A new feature (rancher/elemental-operator#750) was added to the elemental-operator to mark out-of-sync ManagedOSVersions.

Two annotations has been added to ManagedOSVersions (which are created from a ManagedOSVersionChannel):

elemental.cattle.io/channel-last-sync: "2024-06-12T12:24:59Z"
elemental.cattle.io/channel-no-longer-in-sync: "true"

The channel-no-longer-in-sync annotation can be used to highlight the ManagedOSVersion is deprecated and can be deleted.
This should be visible when listing the ManagedOSVersions from the UI extension.

ManagedOSVersions that are no-longer-in-sync can also be excluded from being used during ISO/Disk creation from the UI, however the preference if not too hard to implement, is to allow using these versions but also highlight they are deprecated (with an exclamation mark, tooltip or anything when selecting them).

@aalves08
Copy link
Member

@anmazzotti I believe that what we want is to add a table col in ManagedOSVersions list with in-sync (bool):

Image

And also we should add the label (deprecated) to:

Image

That would be the scope, correct @anmazzotti ?

Question: in what version of elemental-operator will this feature be available?

@anmazzotti
Copy link
Author

Yes that's correct. This will be available in 1.6

Also note that I'm going to add automatic os cleaning, this will be a togglable option when creating the ManagedOSImageChannel: rancher/elemental-operator#759

I'm trying to squeeze this one too. I'll open a new UI issue as soon at it is done, just an heads up for now.

Thank you.

@juadk
Copy link
Collaborator

juadk commented Aug 6, 2024

I will open an issue to automate this test.

Tested with :

  • rancher 2.9.0 / operator 1.6.3 / elemental UI 2.0.0-rc1
  • rancher 2.8.5 / operator 1.6.3 / elemental UI 1.3.1-rc9

Image
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants