Add policy report results to dashboard view #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionality-wise I did not find any problem. I have few suggestions / notes about my initial confusion :)
|
kravciak
reviewed
Aug 16, 2024
| description: An Admission Policy is a namespace-wide resource. The policy will process only the requests that are targeting the Namespace where the Admission Policy is defined. | ||
| linkText: Create Admission Policy | ||
| slotTitle: Policies | ||
| title: Namespace Policies |
There was a problem hiding this comment.
Not sure if this it typo or correct :)
Suggested change
| title: Namespace Policies | |
| title: Namespaced Policies |
kravciak
reviewed
Aug 16, 2024
| slotTitle: Policies | ||
| title: Namespace Policies | ||
| description: Namespace-wide policy validation | ||
| linkText: Create Namespace Policy |
There was a problem hiding this comment.
Same here
Suggested change
| linkText: Create Namespace Policy | |
| linkText: Create Namespaced Policy |
|
Holding off on this until the UX team can take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #798
This adds policy report results to the dashboard view.
Along with the reports added, the layout of the cards has been updated.