Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opni logging should collect traces #1605

Closed
dbason opened this issue Aug 1, 2023 · 3 comments · Fixed by #1607
Closed

Opni logging should collect traces #1605

dbason opened this issue Aug 1, 2023 · 3 comments · Fixed by #1607
Assignees
Labels

Comments

@dbason
Copy link
Contributor

dbason commented Aug 1, 2023

This will involve:

  1. Implementing Export methods for traces in the otel forwarder
  2. Adding a trace pipeline to the otel preprocessor config
  3. Implementing an Export method for traces in the gateway
  4. Adding a trace pipline to the otel config for logging.
@jaehnri
Copy link
Contributor

jaehnri commented Aug 4, 2023

@dbason I have a few questions 😅

  1. I've understood that the logging plugin has a forwarder responsible for sending data to the upstream cluster via OTLP. In the upstream, the component responsible for receiving these OTLP logs is this supportagent?

    type otlpShipper struct {
    otlpShipperOptions
    client collogspb.LogsServiceClient

  2. Is the following the preprocessing and OpenSearch ingestion pipeline?

    pipelines:
    logs:
    receivers: ["otlp"]
    processors: ["resource", "attributes", "transform"]
    exporters: ["opensearch"]
    `))

  3. Why are there otel collectors both downstream and upstream?

@dbason
Copy link
Contributor Author

dbason commented Aug 6, 2023

The supportagent is something different, that's a standalone tool. I'll ping you and we can set up something to go over the artchitecture.

@jaehnri
Copy link
Contributor

jaehnri commented Aug 17, 2023

As of now, there is no support for traces in our custom OpenSearch exporter:
https://github.com/dbason/opentelemetry-collector-contrib/tree/opensearch-exporter/exporter/opensearchexporter

However, there is ongoing development for it (see open-telemetry/opentelemetry-collector-contrib#23611), and traces, specifically, should be added soon (see open-telemetry/opentelemetry-collector-contrib#24540).

For that matter, we planned to pause the development of this feature for now and come back when at least the traces are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants