Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Validate ros cloud-config as much as possible #2693

Closed
niusmallnan opened this issue Mar 1, 2019 · 1 comment
Closed

Validate ros cloud-config as much as possible #2693

niusmallnan opened this issue Mar 1, 2019 · 1 comment

Comments

@niusmallnan
Copy link
Contributor

Now we can use ros config validate to to validate ros cloud-config, this is not enough. In particular, the user manually modifies the config. If the wrong configuration is added, it may cause the startup to fail.

I think we need to enhance the experience and give users friendly tips.

Such as the following:

  1. before the reboot or shutdown
  2. before ros install -c
  3. others if needed
@rootwuj
Copy link

rootwuj commented May 21, 2019

Tested with rancher/os:v1.5.2-rc1 from May 21
Verified fixed

Test:

  • Set the wrong cloud-config
  • Run the reboot or shutdown command
  • Run sudo ros install -c

Result:

  • Display error message and command is not being run.

@rootwuj rootwuj closed this as completed May 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants