-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy ingress-nginx ServiceMonitor in Rancher v2.5 for scraping by Monitoring v2 #30126
Comments
@axeal, yes this is possible. Thanks for providing the Service / ServiceMonitor! This issue will also encompass adding Grafana Dashboards, sourced from nginx.json and request-handling-performance.json |
@aiyengar2 Where to add these json files ? |
@k8w you can add these JSON files via the Rancher UI, here are the relevant docs: https://rancher.com/docs/rancher/v2.x/en/monitoring-alerting/v2.5/persist-grafana/. Since you already have the JSON, all you need to do is the last step. |
@aiyengar2 @sowmyav27 could you please point me how to install the enhanced chart? IIUC it should be available in rancher/charts.git in Should I clone the charts.git locally and deploy it manually or is there a way how to do it from webUI? |
I just successfully installed the testing monitoring chart from my local git checkout.
|
@thehejik weird, I see https://github.com/rancher/charts/tree/dev-v2.5/assets/rancher-monitoring contains 9.4.204-rcXX versions so it should be working. But the approach you did via bash works too. |
@thehejik The RC version of the chart is not available on 2.5-head because the rancher charts by default point to |
Thanks, I had some problems with DNS but now it works correctly. The feature is working as described but so far user has to set
I was testing on rancher 2.5.7 with v2.5-head image tag and used http://git.rancher.io/charts Edit: tested on rancher |
I just updated our 2.5.7 rancher installation to 2.5.8, and updated also our rancher monitoring, but can't get it running somehow. I've enabled
|
You need to define
|
@h0jeZvgoxFepBQ2C see #32416 (comment). If you re-trigger an install, it should successfully install. |
Do you have a link where this is documented? thx! |
Hmm @thehejik when we tested this did we need to update the selector? @quangthe sorry for the late ask, but could you share your environment information that required you to provide a selector in #30126 (comment) so we can attempt to reproduce? Specifically:
Based on the labels shown in https://github.com/kubernetes/ingress-nginx/blob/8b3a6f02526e8bcf8b6fff2bf8d3613e20211b15/deploy/static/provider/cloud/deploy.yaml#L298, it seems like you are right that the default should be to use But I wonder if RKE / RKE2 still deploy ingress-nginx with the other label, which is why we left it as |
@aiyengar2 I don't think I was using the proposed selector, on the other hand I'm not sure if metrics from ingress were shown. |
Hmm in that case, @sowmyav27 I'm re-opening this issue and putting it to test. We need to confirm that setting We should also double check that the Grafana dashboards are eventually populated with metrics if an ingress is added to the cluster. |
Perfect! Thanks for checking @thehejik. @h0jeZvgoxFepBQ2C @quangthe if you are still encountering this issue, please let us know your environment information! Perhaps there’s something we could document that is specific to the environment that you are deploying Monitoring into that requires selectors, but by default updating it should not be required. |
What kind of request is this (question/bug/enhancement/feature request):
Enhancement
Steps to reproduce (least amount of steps as possible):
ingress-nginx-controller
metrics are not scraped by default with Monitoring v2 in Rancher v2.5. For Rancher provisioned clusters with the ingress-nginx ingress controller, would it be possible to auto-deploy a ServiceMonitor and metrics Service similar to the below, which will enable scraping by Prometheus:Environment information
gz#11621
gz#13981
The text was updated successfully, but these errors were encountered: