Change rke2-multus chart to local #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
requested changes
Aug 16, 2023
| @@ -0,0 +1,34 @@ | |||
| ====== | |||
| {{- if or ( gt .Capabilities.KubeVersion.Major "1" ) ( ge .Capabilities.KubeVersion.Minor "16" ) }} | |||
There was a problem hiding this comment.
This condition does not make sense anymore :P
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| {{- if or ( gt .Capabilities.KubeVersion.Major "1" ) ( ge .Capabilities.KubeVersion.Minor "16" ) }} |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| {{- if or ( gt .Capabilities.KubeVersion.Major "1" ) ( ge .Capabilities.KubeVersion.Minor "16" ) }} |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| {{- if or ( gt .Capabilities.KubeVersion.Major "1" ) ( ge .Capabilities.KubeVersion.Minor "16" ) }} |
| cni_conf: | ||
| #skipMultusBinaryCopy: false | ||
| #kubeconfig: /etc/cni/net.d/multus.d/multus.kubeconfig | ||
| cniVersion: 0.3.1 |
There was a problem hiding this comment.
Can you increase this one to 1.0.0?
thomasferrandiz
force-pushed
the
update-multus-chart
branch
from
4067df3
to
84bbe95
Compare
manuelbuil
approved these changes
Aug 17, 2023
thomasferrandiz
force-pushed
the
update-multus-chart
branch
2 times, most recently
from
ca7aa43
to
32e7ce8
Compare
rbrtbnfgl
approved these changes
Aug 18, 2023
Upstream chart is not maintained so this allows us to configure multus deployments properly. Also bump multus image version to latest.
thomasferrandiz
force-pushed
the
update-multus-chart
branch
from
32e7ce8
to
5d8f7f1
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Change rke2-multus chart to local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream chart is not maintained so this allows us to configure multus deployments properly.