Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow klipper-helm image version to be overridden #2160

Closed
AshleyDumaine opened this issue Nov 22, 2021 · 1 comment
Closed

Allow klipper-helm image version to be overridden #2160

AshleyDumaine opened this issue Nov 22, 2021 · 1 comment

Comments

@AshleyDumaine
Copy link

AshleyDumaine commented Nov 22, 2021

Is your feature request related to a problem? Please describe.
I need to use a custom version of klipper-helm (considered a core image since it is found in rke2-images-core.linux-amd64.txt for each release) to address a bug, but it doesn't seem possible to override the version being used by RKE2 unlike for other core images like kube-apiserver, kube-scheduler, etcd, and so on: https://github.com/rancher/rke2/blob/master/pkg/images/images.go#L15-L25

Describe the solution you'd like
I would like if all images found in rke2-images-core.linux-amd64.txt are able to be overridden via the RKE2 CLI / config by adding missing images such as klipper-helm to https://github.com/rancher/rke2/blob/master/pkg/images/images.go

Describe alternatives you've considered
I've considered tagging my custom klipper-helm image as the upstream klipper-helm image desired by my target RKE2 version and adding that to my image registry to use instead of the unmodified upstream image. This is currently working, but it goes against best practices and is stopgap that is undesired as a long-term solution.

Thanks!

@stale
Copy link

stale bot commented May 25, 2022

This repository uses a bot to automatically label issues which have not had any activity (commit/comment/label) for 180 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the bot can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the bot will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant