Migrate from Drone to GHA #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this also removes the FOSSA step! Be sure we create an issue to re-add this at a later date, if we decide to do that.
tomleb
reviewed
May 28, 2024
Co-authored-by: Tom Lebreux <me@tomlebreux.com>
JonCrowther
approved these changes
May 28, 2024
JonCrowther
requested changes
May 28, 2024
JonCrowther
approved these changes
May 28, 2024
|
mockgen dependency moved to this issue for tracking rancher/rancher#45611 |
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lightweight port of the CI logic from Drone into Github Actions, addressing rancher/rancher#45230
Two things to call out here:
This is using the
golangci-lintaction, which performs linting validation as its own step. Later, thevalidate.shscript does its own call togolangci-lint run. For the lightest possible touch I've left this logic alone, in case anyone is relying on the local Makefile for linting during development. For CI purposes this feels redundant; should we perhaps remove the extra call fromvalidate.sh?Secondly, this removes FOSSA scanning, as we are currently stalled on API key provisioning upstream. This will be re-added at a future date, pending rancher/rancher#45495