k8s 1.30 dependencies update #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MbolotSuse
reviewed
Jun 4, 2024
|
|
||
| replace ( | ||
| github.com/crewjam/saml => github.com/rancher/saml v0.2.0 | ||
| github.com/knative/pkg => github.com/rancher/pkg v0.0.0-20181214184433-b04c0947ad2f | ||
| github.com/matryer/moq => github.com/rancher/moq v0.0.0-20190404221404-ee5226d43009 | ||
| k8s.io/client-go => github.com/rancher/client-go v1.29.3-rancher1 |
There was a problem hiding this comment.
Are you sure that we don't need the changes from the client-go fork in steve?
There was a problem hiding this comment.
was about to update the PR comment...it was discussed in PR comment : rancher/client-go#11 (comment)
so with k8s 0.30 client go all fixes have gone into upstream.
There was a problem hiding this comment.
Thanks, I'll leave this thread open so that other reviewers can see it easily, but if all the fixes are upstream then that's a good change.
There was a problem hiding this comment.
https://github.com/rancher/security-team/issues/349#issue-1820307873 has more context on why our custom changes are no longer required.
also updated k8s dependencies to v0.30.1
nflynt
approved these changes
Jun 5, 2024
kinarashah
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: rancher/rancher#45332