Adding APIGroups back to the schema #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior schema calculations started with openapiv2 models which included a model for APIGroups. However, new schema calculations use ServerGroupsAndResources first, which omitted these values. This re-adds this type using a static schema.
ericpromislow
approved these changes
Jul 2, 2024
tomleb
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related to rancher/rancher#45955. Previous changes changed the order that schemas were evaluated in (used to be
models, thenServerGroupsAndResources, is nowServerGroupsAndResources, thenmodels). The APIGroups resource, which is not itself a server group/resource, but is a model, was omitted because of this. This re-adds this custom schema first (so that the description later on can fill in more detail), making the endpoint visible again in steve.Solution Detail
BaseSchemato theapigrouppackage.BaseSchemaforapigroup.addDescriptionwill add a description for this schema.