Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache/sql: add more indexed fields #400

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

moio
Copy link
Contributor

@moio moio commented Dec 3, 2024

Addresses rancher/rancher#48011 and rancher/rancher#48103

Should be backported to 2.9.x after merging

@moio moio requested a review from a team as a code owner December 3, 2024 08:04
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment, otherwise fields look good

pkg/stores/sqlproxy/proxy_store.go Outdated Show resolved Hide resolved
Signed-off-by: Silvio Moioli <silvio@moioli.net>
@moio moio force-pushed the vai_more_indexed_fields branch from 3c0b461 to e11cacd Compare December 3, 2024 09:07
@moio moio requested a review from richard-cox December 3, 2024 09:08
@moio
Copy link
Contributor Author

moio commented Dec 3, 2024

addressed now

Copy link
Contributor

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@prachidamle prachidamle self-requested a review December 6, 2024 19:59
@ericpromislow ericpromislow merged commit 6512945 into rancher:main Dec 6, 2024
1 check passed
@moio moio deleted the vai_more_indexed_fields branch December 10, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants