-
Notifications
You must be signed in to change notification settings - Fork 63
How to cut a Webhook RC
Bruno Bachmann edited this page May 8, 2023
·
11 revisions
-
Determine the next RC for the desired line.
- If the last tag was
v0.3.5-rc2
, then the next tag will bev0.3.5-rc3
- If the last tag was a release with no RC
v0.3.3
, then ask one of the code owners of rancher-webhook which tag to use.
Rancher Version Webhook Branch v2.7 release/v0.3 v2.6 release/v0.2 v2.5 release/v0.1 - If the last tag was
-
On your local machine checkout and pull the latest changes for the desired release branch.
-
Tag HEAD
git tag v0.3.5-rc3
-
Push the new tag to upstream
git push upstream v0.3.5-rc3
-
Wait for CI pipeline started by the new tag to complete.
- This will create a new release and artifacts needed for the next steps https://github.com/rancher/webhook/releases/tag/v0.3.5-rc3
-
Checkout the dev branch for the desired charts line on your local fork.
- For this example, we are on (https://github.com/rancher/charts/tree/dev-v2.7)
-
Create a new branch for your changes.
git checkout -b bump-rancher-webhook-v0.3.5-rc3
-
In the new charts branch, update
release.yaml
andpackage.yaml
with the new RC and commit your changes.- If this is the first RC, also bump the chart version. and add a new item for rancher-webhook in
release.yaml
- commit package.yaml and release.yaml and package message=“Bump Rancher-webhook to v0.3.2-rc5”
- https://github.com/rancher/charts/pull/2605/commits/ed82e962e51a69a53d0afbabeed3aaa2ae657f80
- If this is the first RC, also bump the chart version. and add a new item for rancher-webhook in
-
Run Make Charts and commit your changes.
export PACKAGE=rancher-webhook && make charts
- commit changes in (assets folder/charts folder) message=“Make Charts”
- https://github.com/rancher/charts/pull/2605/commits/121b8d1ca8ba0260cf015d0dafc468a917d194e0
-
(If the previous version was also an RC) Run Make Remove (to remove files created for the previous RC) and commit your changes.
export CHART=rancher-webhook && export VERSION=2.0.3+up0.3.3-rc4 && make remove
- https://github.com/rancher/charts/pull/2605/commits/0d8b1a705bd50775f68dcd6fb6d236a2bc2c4bce
-
Open a new PR for your new branch in rancher/charts
- https://github.com/rancher/charts/pull/2605/
- assign one member of Team 1 as a reviewer.
-
Update Rancher/Rancher to use the new webhook version
- Open PR in rancher/rancher to update
CATTLE_MIN_WEBHOOK_VERSION
in package/Dockerfile - https://github.com/rancher/rancher/pull/41410/commits