Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Update integrated Dropbear to support ed25519 SSH keys #241

Closed
PirMei opened this issue May 28, 2020 · 1 comment
Closed
Labels
invalid This doesn't seem right

Comments

@PirMei
Copy link

PirMei commented May 28, 2020

Describe the bug
Adding SSH keys of type ed25519 over the web interface as well as via dustbuilder service does not allow SSH access, resulting in a fallback to password authentication.

How to Reproduce
Steps to reproduce the behavior:

  1. Add a ssh-ed25519 public key via the web interface or via dustbuilder service
  2. Try to connect via ssh with ssh -i $ssh_key_in_ed25519_format root@roborock
  3. SSH client falls back to password authentication

Expected behavior
SSH ed25519 keys are accepted by the Dropbear SSH server.

Vacuum Model: Roborock S5

Valetudo Version: RE 0.9.4

User-Agent irrelevant

Additional context
Dropbear got support for ed25519 keys with this Pull Request: mkj/dropbear#91
It's not included in an official release yet afaik, but this might be worth to look into in the future.
See also this comment by tripplet: #151 (comment)_

@rand256
Copy link
Owner

rand256 commented May 28, 2020

Dropbear is definitely not a part of Valetudo application, and this is not an image builder repository.
I use vacuumz image builder for creating pre-built images, so that is better place to ask.

@rand256 rand256 closed this as completed May 28, 2020
@rand256 rand256 added the invalid This doesn't seem right label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants