Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #29

Closed
peternewman opened this issue Oct 3, 2020 · 5 comments
Closed

New release? #29

peternewman opened this issue Oct 3, 2020 · 5 comments
Milestone

Comments

@peternewman
Copy link

Hi,

Any chance of a new release so we can have access to all the new sub-places:
v3.2.0...master

@quincylvania
Copy link
Contributor

@peternewman Yes, we definitely need a release soon. There are a few outstanding items to work out…

The big one is that we need a way to say "this feature 1 isn't part of feature 2, but feature 2 has sovereignty over feature 1". For example, the Channel Islands and the British Overseas Territories aren't technically in the UK, so country-coder shouldn't say they are unless you want it to.

Since NSI needs the new detail for Hacktoberfest I'll try to do this soon.

@peternewman
Copy link
Author

@peternewman Yes, we definitely need a release soon. There are a few outstanding items to work out…

The big one is that we need a way to say "this feature 1 isn't part of feature 2, but feature 2 has sovereignty over feature 1". For example, the Channel Islands and the British Overseas Territories aren't technically in the UK, so country-coder shouldn't say they are unless you want it to.

According to this, the Channel Islands are probably in it, depending on what feature 2 is:
https://en.wikipedia.org/wiki/Terminology_of_the_British_Isles#/media/File:British_Isles_Euler_diagram_15.svg

Since NSI needs the new detail for Hacktoberfest I'll try to do this soon.

Great thanks.

@quincylvania
Copy link
Contributor

Done: https://github.com/ideditor/country-coder/releases/tag/v4.0.0

I didn't end up doing anything fancy to solve the UK problem, but I don't think it'll be much of an issue.

@peternewman
Copy link
Author

Thanks @quincylvania , funny enough I was just wondering if there had been any progress.

I assume you just mean this hasn't been implemented yet?

The big one is that we need a way to say "this feature 1 isn't part of feature 2, but feature 2 has sovereignty over feature 1".

@quincylvania
Copy link
Contributor

I assume you just mean this hasn't been implemented yet?

@peternewman Correct. This shouldn't really matter for most use cases, but it's something to keep in mind.

@quincylvania quincylvania added this to the 4.0.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants