Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf improvement: Don't union features iteratively with locationReducer #26

Closed
bhousel opened this issue Dec 30, 2020 · 1 comment
Closed

Comments

@bhousel
Copy link
Contributor

bhousel commented Dec 30, 2020

I made this change in 86ab4ae

In the past, Turf/JSTS/martinez could not easily handle aggregated features, so we'd iteratively union them all together with the _locationReducer function. (this was slow)

Now mfogel/polygon-clipping can handle multiple input coord arrays, so we can send all the coords in one shot and it just works fast

@bhousel bhousel closed this as completed Dec 30, 2020
@bhousel
Copy link
Contributor Author

bhousel commented Dec 30, 2020

Side by side comparison - It's really a lot faster now!

Screen Shot 2020-12-29 at 11 25 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant