Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution packages #204

Open
ddiss opened this issue Mar 13, 2023 · 4 comments
Open

distribution packages #204

ddiss opened this issue Mar 13, 2023 · 4 comments
Assignees

Comments

@ddiss
Copy link
Collaborator

ddiss commented Mar 13, 2023

Now that we've started moving away from magic paths in the rapido directory for rapido.conf and initramfs image output, we can probably consider providing rapido as a distribution package (while retaining all run-from-git-dir functionality). There are still a few things which I think should be cleaned up before we do go down that path though. First things that come to mind:

  • rapido.conf default search paths should probably include a path under $HOME (and perhaps /etc too)
  • initramfs images should be output in the current working directory by default(?)
  • rapido boot should accept an initramfs image path parameter
@ddiss ddiss self-assigned this Mar 13, 2023
@ddiss
Copy link
Collaborator Author

ddiss commented Sep 21, 2023

I've published RFC packages at https://build.opensuse.org/package/show/home:dmdiss:rapido/rapido .
@Werkov you may be interested in pulling these into your container for testing.
There are a number of changes atop the current master branch which I'll submit as an RFC pull request for discussion. The main reason for keeping it RFC is that the default path decisions should be carefully considered.

@Werkov
Copy link
Collaborator

Werkov commented Oct 5, 2023

Invoking rapido (relying on PATH and /usr/bin/rapido) won't properly initialize RAPIDO_DIR (e.g. rapido list returns empty list of available cuts).
Calling /usr/libexec/rapido/rapido works.

@ddiss
Copy link
Collaborator Author

ddiss commented Oct 5, 2023

Invoking rapido (relying on PATH and /usr/bin/rapido) won't properly initialize RAPIDO_DIR (e.g. rapido list returns empty list of available cuts). Calling /usr/libexec/rapido/rapido works.

/usr/bin/rapido is a symlink to the libexec binary path, so RAPIDO_DIR should be properly initialized given that realpath is used. I'll take a closer look. Thanks for the feedback.

@ddiss
Copy link
Collaborator Author

ddiss commented Oct 6, 2023

Invoking rapido (relying on PATH and /usr/bin/rapido) won't properly initialize RAPIDO_DIR (e.g. rapido list returns empty list of available cuts). Calling /usr/libexec/rapido/rapido works.

/usr/bin/rapido is a symlink to the libexec binary path, so RAPIDO_DIR should be properly initialized given that realpath is used. I'll take a closer look. Thanks for the feedback.

Yep, you're right, it's broken. This can be fixed via:

 15 RAPIDO_DIR="$(realpath -e $BASH_SOURCE)"
 16 RAPIDO_DIR="${RAPIDO_DIR%/*}"

...but I'm wondering whether the whole RAPIDO_DIR relative-path calculation should just be dropped in favour of hardcoded paths (with fallback to working directory for git repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants