Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support out-of-source kernel builds #216

Open
Werkov opened this issue Jun 29, 2023 · 1 comment
Open

Support out-of-source kernel builds #216

Werkov opened this issue Jun 29, 2023 · 1 comment

Comments

@Werkov
Copy link
Collaborator

Werkov commented Jun 29, 2023

Disclaimer: the out-of-source builds work just fine for me in the recent version (e0d44a2).

It is only slightly misleading that I set KERNEL_SRC=$BUILD_DIR.
By quickly skimming rapido cuts, KERNEL_SRC is used for build artifacts most of the time. But some cases would need review.

Proposal: introduce a new config variable pointing explicitly to kernel build artifacts.

  • In-source builds (nothing changes, user configures a single path)
    • KERNEL_BUILD=KERNEL_SRC
  • Out-of-source builds (review if separate path is necessary)
    • KERNEL_BUILD=
    • KERNEL_SRC= -- is it needed?
@ddiss
Copy link
Collaborator

ddiss commented Jul 12, 2023

I don't normally use out-of-source builds, so can't really judge whether this would be useful to others - my only real concern with adding support would be that rapido.conf configuration becomes even more complicated. We currently have:

# Path to Linux kernel source. Prior to running "rapido cut", the kernel
# should be built, with modules installed (see KERNEL_INSTALL_MOD_PATH below).
# If KERNEL_SRC is not set then rapido will attempt to boot the local kernel
# present under /boot/.
#
# e.g. KERNEL_SRC="/home/me/linux"
#KERNEL_SRC=""

...which IMO is pretty clear that it needs to be built in-place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants