Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Clarify Supported Type Combinations when creating a SGGraph or MGGraph #4587

Open
Tracked by #3806
alexbarghi-nv opened this issue Aug 2, 2024 · 3 comments
Open
Tracked by #3806
Assignees
Labels
improvement Improvement / enhancement to an existing function

Comments

@alexbarghi-nv
Copy link
Member

When passing an unsupported type combination, the user gets currently gets an undescriptive error message that is meaningless to them unless they understand libcugraph. Instead, we should raise a more descriptive error in pylibcugraph (i.e. int64 is not supported for edge weights).

@alexbarghi-nv alexbarghi-nv self-assigned this Aug 2, 2024
@alexbarghi-nv alexbarghi-nv added the improvement Improvement / enhancement to an existing function label Aug 2, 2024
@ChuckHastings
Copy link
Collaborator

What are you looking for here in terms of behavior? Are you calling python functions for creating SGGraph and MGGraph, or are you calling PLC directly?

Typically we have addressed this in the python layer by adding checks before even calling the PLC/C API. If you're calling python functions for creating SGGraph and MGGraph then we might need to look at what checks are in that code. If you're calling PLC functions directly then we would need to address it there.

The C API should raise the exception: "Type Dispatcher executing unsupported combination of types". Getting a more specific message will be a bit more complicated, but certainly possible if we need it to be done in the C API.

@alexbarghi-nv
Copy link
Member Author

I think this should be done in pylibcugraph, as is done for some other code. cuGraph-PyG/DGL directly calls pylibcugraph.

@alexbarghi-nv
Copy link
Member Author

I'm suggesting we do a check in the pylibcugraph API before it even calls the C API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function
Projects
None yet
Development

No branches or pull requests

2 participants