Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin two notebook-env packages #609

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

raydouglass
Copy link
Member

Temporary solution for jupyter-server/jupyter_server#1198

@raydouglass raydouglass requested a review from a team as a code owner February 3, 2023 18:01
@raydouglass raydouglass self-assigned this Feb 3, 2023
Comment on lines +94 to +96
# TODO Update jupyter_core_version once https://github.com/jupyter-server/jupyter_server/issues/1198 is resolved
jupyter_core_version:
- '=5.1.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my testing this seemed unnecessary, just ipykernel was needed. I doesn't seem to harm either though, so I'll leave it up to you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I want to be overly cautious here since we are so close to the release.

@raydouglass raydouglass merged commit 49ffbe0 into rapidsai:branch-23.02 Feb 3, 2023
@raydouglass raydouglass deleted the notebook-pins branch February 3, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants