cufile version #565
Merged
cufile version #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
reviewed
Dec 4, 2024
Added #566 |
Co-authored-by: Lawrence Mitchell <wence@gmx.li>
vyasr
approved these changes
Dec 4, 2024
| @@ -10,6 +11,24 @@ | |||
| DriverProperties = cufile_driver.DriverProperties | |||
|
|
|||
|
|
|||
| def libcufile_version() -> Tuple[int, int]: | |||
| """Get the libcufile version (or zero if older than v1.8). | |||
There was a problem hiding this comment.
Minor note that this returns (0, 0) and not 0 for old versions. I would suggest removing the parenthetical here and instead specifying that behavior in the Notes below.
There was a problem hiding this comment.
Changed to:
def libcufile_version() -> Tuple[int, int]:
"""Get the libcufile version.
Returns (0, 0) for cuFile versions prior to v1.8.
Notes
-----
This is not the version of the CUDA toolkit. cufile is part of the
toolkit but follows its own version scheme.
Returns
-------
The version as a tuple (MAJOR, MINOR).
"""
bdice
reviewed
Dec 4, 2024
Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com> Co-authored-by: Bradley Dice <bdice@bradleydice.com>
bdice
approved these changes
Dec 4, 2024
|
Thanks everyone |
jakirkham
reviewed
Dec 4, 2024
Co-authored-by: jakirkham <jakirkham@gmail.com>
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #566
To clean up and make cufile capability detection more robust, we now use
cuFileGetVersion().Should fix the nightly failure: https://github.com/rapidsai/kvikio/actions/runs/12133477083/job/33877440755
NB:
cuFileGetVersion()first became available in cufile v1.8 (CTK v12.3) thus the stream and batch API detection will return false for versions older than v1.8. I think this is acceptable for robustness.