Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Commit

Permalink
Fix dependencies on librmm and libraft. (#96)
Browse files Browse the repository at this point in the history
The package currently has runtime dependencies on librmm and libraft-headers. However, these packages are header-only, so it's only sensible to require them at build time. This PR removes librmm and libraft-headers from the runtime dependencies of libwholegraph.

This PR is needed to fix the conda environments in [unified devcontainers](https://github.com/rapidsai/devcontainers).

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #96
  • Loading branch information
bdice authored Nov 21, 2023
1 parent 405d86c commit 7a3c873
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-118_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
- c-compiler
- clang-tools=16.0.0
- clangxx=16.0.0
- cmake>=3.23.1,!=3.25.0
- cmake>=3.26.4
- cuda-nvtx=11.8
- cudatoolkit=11.8
- cudnn=8.4
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-120_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ dependencies:
- c-compiler
- clang-tools=16.0.0
- clangxx=16.0.0
- cmake>=3.23.1,!=3.25.0
- cmake>=3.26.4
- cuda-cudart-dev
- cuda-nvcc
- cuda-nvtx
Expand Down
2 changes: 0 additions & 2 deletions conda/recipes/libwholegraph/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,6 @@ outputs:
- cudatoolkit
{% endif %}
- libraft ={{ minor_version }}
- libraft-headers ={{ minor_version }}
- librmm ={{ minor_version }}
- nccl {{ nccl_version }}
about:
home: https://rapids.ai/
Expand Down
12 changes: 6 additions & 6 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,15 @@ dependencies:
- output_types: conda
packages:
- c-compiler
- cmake>=3.23.1,!=3.25.0
- cmake>=3.26.4
- cudnn=8.4
- nccl
- cxx-compiler
- nanobind>=0.2.0
- cython
- doxygen=1.8.20
- libraft-headers==23.12.*
- librmm==23.12.*
- nanobind>=0.2.0
- nccl
- scikit-build
specific:
- output_types: conda
Expand Down Expand Up @@ -163,9 +165,7 @@ dependencies:
run:
common:
- output_types: [conda, requirements]
packages:
- libraft-headers==23.12.*
- librmm==23.12.*
packages: []
test_cpp:
common:
- output_types: [conda, requirements]
Expand Down

0 comments on commit 7a3c873

Please sign in to comment.