Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ue5 devel humble size specified #107

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Ue5 devel humble size specified #107

merged 1 commit into from
Oct 30, 2023

Conversation

phs4530
Copy link
Contributor

@phs4530 phs4530 commented Oct 27, 2023

uint is not a built-in type in Unreal Engine. I think it would be better to use a type like uint32 or uint16 instead.

@phs4530 phs4530 changed the base branch from devel to UE5_devel_humble October 27, 2023 02:12
@yuokamoto
Copy link
Contributor

Thanks for your PR.
I think it is better to use uint8 since ROS 2 UUID is uint8
https://docs.ros2.org/foxy/api/unique_identifier_msgs/msg/UUID.html

@phs4530
uint data size specified
389fbe3 
- uint -> uint8
@phs4530 phs4530 force-pushed the UE5_devel_humble_size_specified branch from 8812d77 to 389fbe3 Compare October 30, 2023 01:30
@phs4530
Copy link
Contributor Author

phs4530 commented Oct 30, 2023

Thank you for your comment.
I also think uint8 is better than uint32.
I modified my commit!

  • uint32 -> uint8

@yuokamoto yuokamoto merged commit a1c338b into rapyuta-robotics:UE5_devel_humble Oct 30, 2023
@yuokamoto
Copy link
Contributor

Thank you. merged.

@yuokamoto yuokamoto mentioned this pull request Oct 30, 2023
Merged
@phs4530 phs4530 mentioned this pull request Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phs4530 @yuokamoto