Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rasa_events to customizable keys and rename structlog keys #12516

Merged

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Jun 16, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt marked this pull request as ready for review June 16, 2023 15:07
@Tawakalt Tawakalt requested a review from a team as a code owner June 16, 2023 15:07
@Tawakalt Tawakalt requested review from ancalita and removed request for a team June 16, 2023 15:07
rasa/nlu/test.py Outdated
@@ -1012,7 +1015,7 @@ def find_intersecting_entities(token: Token, entities: List[Dict]) -> List[Dict]
candidates.append(e)
structlogger.debug(
"test.intersecting.entities",
token_text=token.text,
token_text=copy.deepcopy(token.text),
token_start=token.start,
token_end=token.end,
entity=e,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't entity be deep copied too?

@@ -30,13 +30,14 @@ def _anonymizer(
"response",
"slot_candidates",
"rasa_event",
"rasa_events",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't seem to leave a comment for prediction_events in L26, I don't think I saw it deep-copied in the place where it's being used? Please double-check 🙏🏻

@Tawakalt Tawakalt requested a review from ancalita June 19, 2023 10:27
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12516--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Tawakalt Tawakalt enabled auto-merge June 19, 2023 10:36
@Tawakalt Tawakalt merged commit 2e1c968 into 3.6.x Jun 19, 2023
@Tawakalt Tawakalt deleted the ATO-1188-enable-anonymization-of-struclog-key-rasa-events branch June 19, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants