Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp installation page #4311

Merged
merged 11 commits into from
Aug 27, 2019
Merged

Revamp installation page #4311

merged 11 commits into from
Aug 27, 2019

Conversation

msamogh
Copy link
Contributor

@msamogh msamogh commented Aug 23, 2019

Proposed changes:

  • Fix https://github.com/RasaHQ/roadmap/issues/644
  • Organize instructions for different operating systems
  • Organize instructions for virtualenv / no virtualenv
  • Make it obvious that installation has completed after "Quick Install"
  • Link to installation guide
  • Link to NLU pipeline specific installation

@msamogh msamogh requested review from akelad and removed request for akelad August 23, 2019 09:42
@msamogh msamogh marked this pull request as ready for review August 23, 2019 17:27
docs/user-guide/installation.rst Outdated Show resolved Hide resolved
docs/user-guide/installation.rst Outdated Show resolved Hide resolved
@msamogh msamogh requested a review from amn41 August 27, 2019 11:29
Copy link
Contributor

@amn41 amn41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! few suggestions

docs/user-guide/installation.rst Show resolved Hide resolved
docs/user-guide/installation.rst Outdated Show resolved Hide resolved
docs/user-guide/installation.rst Outdated Show resolved Hide resolved
@msamogh msamogh requested a review from amn41 August 27, 2019 14:27
@amn41
Copy link
Contributor

amn41 commented Aug 27, 2019

ready to go once build completes

@msamogh msamogh merged commit 179b6b2 into 1.2.x Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants