Make Rasa X model pull interval configurable in local mode

[btotharye]

Proposed changes:

• Updated the x.py CLI file to give a warning if we are about to modify the endpoints.yml and also actually use the wait_time_between_pulls from the source endpoints.yml file.

Status (please check what you already did):

• made PR ready for code review
• added some tests for the functionality - will do this after proposed changes are signed off
• updated the changelog
• reformat files using black (please check Readme for instructions)

[btotharye]

let me know what you think @wochinge this is just the first round, although I don't see Rasa X replacing my config if I put custom stuff in my endpoints.yml file

[wochinge]

Logic looks good! I left a couple of suggestions to polish it a bit. Can we please also write test(s)?

[wochinge]

👍

[btotharye]

ok @wochinge I think all your recent feedback has been implemented now.

[btotharye]

fixing the linting issue, forgot to run that before pushing up

[btotharye]

ok @wochinge all your requested changes should be updated and I fixed the changelog conflict, all tests are passing let me know any other feedback

[wochinge]

looks great! Can you please also write unit test(s) for it?
Also, this pr should probably go against 1.4.x (please make sure your changelog entries end up in the section)

[btotharye]

looks great! Can you please also write unit test(s) for it?
Also, this pr should probably go against 1.4.x (please make sure your changelog entries end up in the section)

Yep I was gonna write the tests after we agreed on how it all is which we do now so I'll work on that next and fix the changelog

[btotharye]

will be working on the tests today/tomorrow to finish this up

[erohmensing]

@btotharye can you give the PR a more descriptive name while you're at it?

[btotharye]

@btotharye can you give the PR a more descriptive name while you're at it?

done

[wochinge]

Great work!

[btotharye]

Great work!

Any idea @wochinge why this is failing now? All I did was update it from the recent master updates

[btotharye]

pretty sure I got the issues resolved if this all passes @wochinge I'll merge it

[btotharye]

Looks like it was a simple thing to fix @wochinge I'm pushing up the changes these tests should pass now.

[btotharye]

re-running tests from the update @wochinge if they pass which they should merging this one

[btotharye]

@wochinge can we merge this one? I'm not sure why the tests are showing funky, on the site it shows coverage increased.

[wochinge]

@btotharye Now you deleted your own changelog 😆

[btotharye]

@btotharye Now you deleted your own changelog 😆

ha let me double check it, crap

[btotharye]

ok @wochinge the changelog should be updated now sorry about that

[wochinge]

@btotharye Please put it in the changelog for 1.6.0a1 since 1.5.0 was already released

[btotharye]

sorry fixed wasn't paying attention there I was in 1.5.x mode