Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twilio Connector Doesn't Use media_url option #4682

Closed
btotharye opened this issue Oct 28, 2019 · 4 comments · Fixed by #5181
Closed

Twilio Connector Doesn't Use media_url option #4682

btotharye opened this issue Oct 28, 2019 · 4 comments · Fixed by #5181
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@btotharye
Copy link
Contributor

btotharye commented Oct 28, 2019

Rasa version: 1.4.x

Python version: 3.7.4

Issue:
The twilio connector doesn't use the new media_url options for sending the images as actual images instead of url links to click.

Payload example:

2019-10-28 08:07:37 INFO     twilio.http_client  - POST Request: https://api.twilio.com/2010-04-01/Accounts/ACac0879f253cd675c17ba7b8120f84921/Messages.json
2019-10-28 08:07:37 INFO     twilio.http_client  - PAYLOAD: {'To': '+xxx', 'From': '+xxx', 'Body': 'Image: https://i.imgur.com/nGF1K8f.jpg'}
2019-10-28 08:07:37 INFO     twilio.http_client  - POST Response: 201 {"sid": "SMb53fb28edc784a458a1596710599ea50", "date_created": "Mon, 28 Oct 2019 12:07:37 +0000", "date_updated": "Mon, 28 Oct 2019 12:07:37 +0000", "date_sent": null, "account_sid": "xxx", "to": "+xxx", "from": "+xxx", "messaging_service_sid": null, "body": "Sent from your Twilio trial account - Image: https://i.imgur.com/nGF1K8f.jpg", "status": "queued", "num_segments": "1", "num_media": "0", "direction": "outbound-api", "api_version": "2010-04-01", "price": null, "price_unit": "USD", }

Example Screenshot:
image

We should be able to use the image payload from rasa and use that with

message = client.messages.create(
                              body='Hello there!',
                              from_='+15555555555',
                              media_url=['https://demo.twilio.com/owl.png'],
                              to='+12316851234'
                          )
@btotharye btotharye added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Oct 28, 2019
@wochinge
Copy link
Contributor

that's more an enhancement isn't it?

@erohmensing
Copy link
Contributor

The twilio connector doesn't use the new media_url options

does this require upgrading the twilio wrapper?

@btotharye btotharye added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Oct 28, 2019
@btotharye
Copy link
Contributor Author

The twilio connector doesn't use the new media_url options

does this require upgrading the twilio wrapper?

not sure I need to look at the wrapper and see what it currently has but I'm hoping it already has this and just the connector needs to be updated

@stale
Copy link

stale bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants