Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket debug logs clog up debug feed #4792

Closed
erohmensing opened this issue Nov 19, 2019 · 3 comments
Closed

socket debug logs clog up debug feed #4792

erohmensing opened this issue Nov 19, 2019 · 3 comments
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework status:stale type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@erohmensing
Copy link
Contributor

When trying to debug a bot that i'm running over socket, I find it really hard as my logs are clogged up with websocket stuff, which to me doesn't mean anything (maybe the ping pong is somewhat helpful, but not really)

019-11-19 14:06:11 DEBUG    websockets.protocol  - undefined - received solicited pong: 86b6b2af
2019-11-19 14:06:21 DEBUG    websockets.protocol  - undefined < Frame(fin=True, opcode=1, data=b'2', rsv1=False, rsv2=False, rsv3=False)
2019-11-19 14:06:21 INFO     engineio.server  - 9b5a104be6f4485fa5133f4d26714f68: Received packet PING data None
2019-11-19 14:06:21 INFO     engineio.server  - 9b5a104be6f4485fa5133f4d26714f68: Sending packet PONG data None
2019-11-19 14:06:21 DEBUG    websockets.protocol  - undefined > Frame(fin=True, opcode=1, data=b'3', rsv1=False, rsv2=False, rsv3=False)
2019-11-19 14:06:31 DEBUG    websockets.protocol  - undefined > Frame(fin=True, opcode=9, data=b'\xa0b\x1cz', rsv1=False, rsv2=False, rsv3=False)
2019-11-19 14:06:31 DEBUG    websockets.protocol  - undefined < Frame(fin=True, opcode=10, data=b'\xa0b\x1cz', rsv1=False, rsv2=False, rsv3=False)
2019-11-19 14:06:31 DEBUG    websockets.protocol  - undefined - received solicited pong: a0621c7a
2019-11-19 14:06:46 DEBUG    websockets.protocol  - undefined < Frame(fin=True, opcode=1, data=b'2', rsv1=False, rsv2=False, rsv3=False)
2019-11-19 14:06:46 INFO     engineio.server  - 9b5a104be6f4485fa5133f4d26714f68: Received packet PING data None
2019-11-19 14:06:46 INFO     engineio.server  - 9b5a104be6f4485fa5133f4d26714f68: Sending packet PONG data None
2019-11-19 14:06:46 DEBUG    websockets.protocol  - undefined > Frame(fin=True, opcode=1, data=b'3', rsv1=False, rsv2=False, rsv3=False)

would be nice if we can hide that stuff or make it configurable not to show it.

@erohmensing erohmensing added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:question 💬 Question around usage, examples area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed type:question 💬 Question around usage, examples labels Nov 19, 2019
@erohmensing
Copy link
Contributor Author

This is truly unbearable when we have the socket connector in the html for the docs pages -- multiple debug logs per second from websockets.protocol will probably take up a lot of storage with that many logs.

@stale
Copy link

stale bot commented Feb 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale label Feb 19, 2020
@erohmensing
Copy link
Contributor Author

Oh, I fixed this in #4915. Oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework status:stale type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

1 participant