Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validator.py warnings #4795

Merged
merged 14 commits into from
Dec 3, 2019
Merged

Update validator.py warnings #4795

merged 14 commits into from
Dec 3, 2019

Conversation

imLew
Copy link
Contributor

@imLew imLew commented Nov 19, 2019 •
edited
Loading

Proposed changes:

  • change some warnings to debug messages, (they are reporting things that are not necessarily wrong)
  • add stacklevel=2 to warnings.warn

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@imLew imLew requested a review from erohmensing November 19, 2019 16:50
erohmensing
erohmensing approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General functionality is great. Few points:

  • can we add documentation on the Validator page that tells you that --debug can be used to find issues more related to clean up versus actual error, e.g. it will tell you if you have intents in your domain that are never used in your stories
  • stacklevel=2 is amazing. Can we look into making this project-wide by either finding a way to set this globally (might be possible) or making a util for warnings.warn? Happy to make an issue for that.
  • changelog file please

rasa/core/validator.py Outdated Show resolved Hide resolved
@tmbo
Copy link
Member

tmbo commented Nov 28, 2019

when you add a changelog entry please make sure NOT to modify CHANGELOG.rst but create a file in changelog/

@imLew imLew merged commit 3529fce into master Dec 3, 2019
@imLew imLew deleted the intent-not-found branch December 3, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imLew @tmbo @erohmensing