Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Connector: support app mentions and direct messaging #4811

Closed
kearnsw opened this issue Nov 21, 2019 · 15 comments
Closed

Slack Connector: support app mentions and direct messaging #4811

kearnsw opened this issue Nov 21, 2019 · 15 comments
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@kearnsw
Copy link
Contributor

kearnsw commented Nov 21, 2019

Description of Problem: I experienced the same issue as #3085 and #3252. Both went unsolved, and I believe the root cause is that the bot should be reading the channel information from the JSON request. From my perspective, the default behavior would look something like:

  1. The bot responds when mentioned
  2. The bot responds to direct messages
  3. If configured, the bot will respond on a channel regardless of 1 and 2.

Overview of the Solution: I took the first steps toward this solution by reading the incoming channel, channel type, and message type from the JSON request. I used this data to implement items 1-3 above.

Definition of Done: Currently, this solves the immediate issue of the bot not responding. However, I am not yet certain about how sessions are managed. I would propose that the bot should also be monitoring who is speaking in the case of a direct message and saving the sessions to a tracker store. In the case of multiparty dialog, another solution would be needed.

@kearnsw kearnsw added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Nov 21, 2019
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀@tabergma will get back to you about it soon!✨

@erohmensing
Copy link
Contributor

erohmensing commented Nov 21, 2019

Hey @kearnsw, overall I think this is a great idea. To clarify, you think the default behavior should be:

Channel configred:

  • bot listens in channel and responds there

No channel configured:

  • bot is available via DM and also responds in any channel when mentioned

Is that correct? Or in the case of channel configured do you want all 3?

I would propose that the bot should also be monitoring who is speaking in the case of a direct message and saving the sessions to a tracker store

Agreed.

With respect to the bot responding when mentioned though, how do you expect that to look? I feel like that goes along with In the case of multiparty dialog, another solution would be needed. -- if you mention the bot in a channel with other people, how do you want it to know who in the channel is talking to the bot -- does the user have to mention the bot at every conversation turn?

@kearnsw
Copy link
Contributor Author

kearnsw commented Nov 21, 2019

Hi @erohmensing 👋,

In case of channel configured, I’m suggesting all three, at least if the docs stay the way they are. I think this is causing the confusion since people assume they can test the bot through DM.

Yes, as currently configured in the PR, the bot would need to be mentioned during each turn unless the bot is configured to respond on that channel. In my organizations, everyone tends to tag each other in each post anyway so this wouldn’t be outside the norm in our case. Unless the bot is a super human conversationalist, I’d anticipate the user wanting others to continue the conversation past a couple turns in most cases.

@mehdiHadji
Copy link

I'm too facing this issue, generally what i do is install the bot on slack in every block (no response from the bot).
I noticed that the bot really respond to the user msg but the problem is the responf is not displayed on slack...

@tabergma tabergma added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Dec 18, 2019
@zaidalvi
Copy link

zaidalvi commented Feb 9, 2020

Hi guys. I too am facing this issue. Rasa is receiving my message through but is unable to display the message that is sent back from Rasa. Any update on this issue?

@kearnsw
Copy link
Contributor Author

kearnsw commented Feb 9, 2020

@zaidalvi are you triyng to send as a direct message or using the @ symbol? Can you share your config? There is a fix that is under review, but I should be able to help you get it running in the short-term.

@zaidalvi
Copy link

zaidalvi commented Feb 9, 2020

I am sending a direct message.
In my terminal it says 200 ok but I can't see a response on slack.

Screen Shot 2020-02-10 at 12 31 11 AM

Screen Shot 2020-02-10 at 12 31 52 AM

Screen Shot 2020-02-10 at 12 32 50 AM

Screen Shot 2020-02-07 at 11 28 39 PM

@kearnsw
Copy link
Contributor Author

kearnsw commented Feb 9, 2020

Thanks! This is most likely the same issue that I experienced. Try using this build with an updated slack connector that should resolve the issue (with no changes on your part): https://github.com/kearnsw/rasa
It should be merged with the main project soon, so please let me know if you run into any issues with it.

@zaidalvi
Copy link

zaidalvi commented Feb 9, 2020

Thank you for your fast reply @kearnsw. I'm sorry I am really new to rasa and slack. Can you please tell me what I have to do to use the new connector or if there's a some sort of a tutorial?

@co-learning-lounge
Copy link

@zaidalvi Check this.

@glauciams
Copy link

@kearnsw I've been having the same issue, followed what's suggested on the threads but still nothing. Is this solved or not yet? I wanted to deploy the bot to have a few (3) users testing it, is there another easy way to deploy it? I've tried rasa x with ngrok but it's too slow, the bot does not work properly (don't recognize intents, for example) and I can't keep track of the questions being asked. Thank you!

@kearnsw
Copy link
Contributor Author

kearnsw commented Mar 19, 2020

Hi @glauciams , this was partially solved in #4812 . There is still need for support to maintain sessions with multiple users. Although, I know there were several additional changes from the Rasa team in recent weeks. As for not recognizing intents, that should be unrelated to the problem described on this thread. You've followed this guide correct (Slack Connector)?

@tmbo tmbo added area:rasa-oss/channels 📞 Issues focused around rasas input and output channels and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Nov 17, 2020
@alwx alwx added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Jan 28, 2021
@alwx
Copy link
Contributor

alwx commented Jan 28, 2021

@kearnsw are you still working on this one?

@kearnsw
Copy link
Contributor Author

kearnsw commented Jan 28, 2021

@alwx , I am not currently working on this issue. I think everything listed in this issue is now resolved, as I have a bot currently handling sessions with multiple slack users which appears to be the only remaining concern of this issue last time I checked. Did you run into any problem with the slack connector related to this issue? If not, I can go ahead and close it.

@rasabot-exalate rasabot-exalate added area:rasa-oss :ferris wheel: area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss :ferris wheel: labels Mar 17, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added area:rasa-oss/channels 📞 Issues focused around rasas input and output channels and removed area:rasa-oss/channels_📞 labels Mar 17, 2022
@rasabot-exalate rasabot-exalate added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed type:enhancement_:sparkles: labels Mar 21, 2022 — with Exalate Issue Sync
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 19, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests