Multiple links in message - Slack sanitization #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multi links will be converted to original content
tmbo
requested changes
Nov 22, 2019
|
@tmbo can you let me know where i need to do that? |
|
@vigneshp826 you could add examples here: https://github.com/RasaHQ/rasa/blob/master/tests/core/test_channels.py#L464 |
|
@vigneshp826 are you still planning on finishing this PR? |
|
@erohmensing little bit busy in my BAU activities. Will try t complete next week. Sorry for the delay |
|
Okay, just wanted to check it wasn't going stale. The mechanism for changelog has changed since, please remove your changelog file and follow these instructions |
test case addition for converting garbled url's into actuals
|
@tmbo @erohmensing added the test piece of code and changelog, let me know if any changes required |
tmbo
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
multiple links if present.
Status (please check what you already did):
black(please check Readme for instructions)