Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make order of files loaded consistent #4898

Merged
merged 3 commits into from
Dec 4, 2019
Merged

Make order of files loaded consistent #4898

merged 3 commits into from
Dec 4, 2019

Conversation

akelad
Copy link
Contributor

@akelad akelad commented Dec 4, 2019 •
edited
Loading

Proposed changes:

  • When you have subdirectories in your training data directory os.walk won't return the files in the same order each time. This leads to inconsistent training results when using a random_seed.
  • Now we sort the files to ensure consistency

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@akelad akelad requested a review from wochinge December 4, 2019 10:59
tmbo
tmbo approved these changes Dec 4, 2019
View reviewed changes
rasa/data.py Show resolved Hide resolved
@akelad akelad removed the request for review from wochinge December 4, 2019 14:09
@akelad akelad merged commit acedba4 into 1.5.x Dec 4, 2019
@akelad akelad deleted the fix_file_order branch December 4, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akelad @tmbo