Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use empty domain in case Domain is None (e.g. if it's a NLU only model) #4989

Merged
merged 4 commits into from
Dec 18, 2019
Merged

use empty domain in case Domain is None (e.g. if it's a NLU only model) #4989

merged 4 commits into from
Dec 18, 2019

Conversation

wochinge
Copy link
Contributor

Proposed changes:

  • use an empty domain in case a model is loaded which has no domain (avoids error when access agent.doman.<some attribute>

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from tabergma December 18, 2019 09:37
@wochinge wochinge force-pushed the empty-domain-for-nlu-models branch from deb5921 to a2e6804 Compare December 18, 2019 09:39
tabergma
tabergma approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

changelog/4989.bugfix.rst Outdated Show resolved Hide resolved
rasa/core/agent.py Show resolved Hide resolved
@wochinge
Copy link
Contributor Author

if it doesn't make it I'll put it in 1.6.x

@wochinge wochinge changed the base branch from master to 1.6.x December 18, 2019 15:33
@wochinge wochinge merged commit 1d9fc56 into 1.6.x Dec 18, 2019
@wochinge wochinge deleted the empty-domain-for-nlu-models branch December 18, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @tabergma