Setting config flags in domain is ignored

[IgNoRaNt23]

There's the option to set flags in the domain via
config: store_entities_as_slots: true

where store_entites_as_slots = True is the default value used, when no option is entered. See

rasa/rasa/core/domain.py

Line 344 in 80ab6e8

store_entities_as_slots: bool = True,

Now, if a domain is created and the value is manually set to false. The setting will be ignored and be set to true. For example, if a model is trained with said domain, the domain-file that is saved in the model tar-file, will have the value set to true again.

This is a blocker for #4884

Rasa version:
1.61

Python version:
3.6.9

Operating system (windows, osx, ...):
Ubuntu

Issue:
See above

Content of domain file before model training (domain.yml) (if relevant):

intents:
  - greet
  - goodbye
  - affirm
  - deny
  - mood_great
  - mood_unhappy
  - bot_challenge

actions:
- utter_greet
- utter_cheer_up
- utter_did_that_help
- utter_happy
- utter_goodbye
- utter_iamabot

templates:
  utter_greet:
  - text: "Hey! How are you?"

  utter_cheer_up:
  - text: "Here is something to cheer you up:"
    image: "https://i.imgur.com/nGF1K8f.jpg"

  utter_did_that_help:
  - text: "Did that help you?"

  utter_happy:
  - text: "Great, carry on!"

  utter_goodbye:
  - text: "Bye"

  utter_iamabot:
  - text: "I am a bot, powered by Rasa."

config:
  store_entities_as_slots: false

Content of domain file inside trained model tar-file (core/domain.yml) (if relevant):

actions:
- utter_cheer_up
- utter_did_that_help
- utter_goodbye
- utter_greet
- utter_happy
- utter_iamabot
config:
  store_entities_as_slots: true
entities: []
forms: []
intents:
- greet:
    ignore_entities: []
    use_entities: true
- goodbye:
    ignore_entities: []
    use_entities: true
- affirm:
    ignore_entities: []
    use_entities: true
- deny:
    ignore_entities: []
    use_entities: true
- mood_great:
    ignore_entities: []
    use_entities: true
- mood_unhappy:
    ignore_entities: []
    use_entities: true
- bot_challenge:
    ignore_entities: []
    use_entities: true
slots: {}
templates:
  utter_cheer_up:
  - image: https://i.imgur.com/nGF1K8f.jpg
    text: 'Here is something to cheer you up:'
  utter_did_that_help:
  - text: Did that help you?
  utter_goodbye:
  - text: Bye
  utter_greet:
  - text: Hey! How are you?
  utter_happy:
  - text: Great, carry on!
  utter_iamabot:
  - text: I am a bot, powered by Rasa.

[sara-tagger]

Thanks for the issue, @ArjaanBuijk will get back to you about it soon!

You may find help in the docs and the forum, too 🤗

[IgNoRaNt23]

Anything happening here?

[wochinge]

Hi @IgNoRaNt23 Thanks for bringing this up and sorry for the late reply! I'll look into it this week!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[wochinge]

@IgNoRaNt23 Guess what I found in my todo list today 🤦‍♂️ Sorry for the very long wait time. Prepared a fix for it in https://github.com/RasaHQ/rasa/pull/6460/files and gonna do a patch release for this asap.