Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make integer primary key compatible with oracle #5197

Merged
merged 12 commits into from
Feb 13, 2020
Merged

make integer primary key compatible with oracle #5197

merged 12 commits into from
Feb 13, 2020

Conversation

akelad
Copy link
Contributor

@akelad akelad commented Feb 7, 2020 •
edited
Loading

Proposed changes:

  • Change SQLTrackerStore to use a primary key compatible with oracle

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@akelad akelad requested a review from wochinge February 7, 2020 13:38
wochinge
wochinge reviewed Feb 10, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🎉

changelog/5197.bugfix.rst Outdated Show resolved Hide resolved
changelog/5197.bugfix.rst Outdated Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/api/tracker-stores.rst Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
rasa/core/utils.py Outdated Show resolved Hide resolved
rasa/core/utils.py Outdated Show resolved Hide resolved
@akelad akelad requested a review from wochinge February 10, 2020 10:48
wochinge
wochinge approved these changes Feb 10, 2020
View reviewed changes
changelog/5197.bugfix.rst Show resolved Hide resolved
rasa/core/tracker_store.py Outdated Show resolved Hide resolved
@akelad akelad merged commit 8647eb7 into 1.7.x Feb 13, 2020
@akelad akelad deleted the oracle-compatibility branch February 13, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akelad @wochinge