Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full intent name to ranked responses #5690

Merged
merged 14 commits into from
Apr 23, 2020

Conversation

hotzenklotz
Copy link
Contributor

@hotzenklotz hotzenklotz commented Apr 21, 2020

Proposed changes:

  • When using a ResponseSelector a user action has access to the full_retrieval_intent property for the predicted response. Additionally, the ResponseSelector provides a ranking of all predicted responses with only the properties ´nameandconfidence`.

  • For downstream tasks it would be useful to have the full_retrieval_intent property also available for the ranked responses. This PR adds this feature.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

…esponse_intents

* 'response_intents' of github.com:hotzenklotz/rasa: (37 commits)
  fix style issue in test_evaluation
  fix deepsource sequence lengths error
  fix golden inputs in case mask loss is on in diet
  Update docs/user-guide/building-assistants.rst
  fix typo in type def, plus remove redundant comment
  fix typo in forms doc
  add changelog
  set regularization constant to 0.001
  prepared release of version 1.9.6
  rename changelog file
  use correct config param
  apply activation if transformer used
  ci cd docs based on 1.9
  add changelog
  move activation to transformer block
  fix formatting issues
  Update stories_trip_circuit_breaker.md
  Update end_to_end_trips_circuit_breaker.md
  Update tests/core/test_evaluation.py
  Update tests/core/test_evaluation.py
  ...
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @melindaloubser1 will take a look at it as soon as possible ✨

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 can you please add a test to tests/nlu/selectors/test_selectors.py ?

changelog/5690.improvement.rst Outdated Show resolved Hide resolved
@tmbo tmbo removed the request for review from indam23 April 22, 2020 09:15
@tmbo tmbo added this to the Rasa 1.10 milestone Apr 22, 2020
hotzenklotz and others added 3 commits April 22, 2020 11:21
Co-Authored-By: Tom Bocklisch <tom@rasa.com>
…esponse_intents

* 'response_intents' of github.com:hotzenklotz/rasa:
  Update changelog/5690.improvement.rst
  fix defaults in docs
  fix number reference for changelog for preveous PR
  only apply input dropout to text
  add dense input dropout as a parameter
  Update changelog/5636.bugfix.rst
  add pass training to input dropout
  update changelog
  add dropout before ffnn
@hotzenklotz
Copy link
Contributor Author

@tmbo I extended a test to cover the ranking property and make sure it has a full_retrieval_intent property.

tests/nlu/selectors/test_selectors.py Outdated Show resolved Hide resolved
@tmbo tmbo merged commit ac691e3 into RasaHQ:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants